-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved image sizes
for left/right/center alignment
#1289
Comments
@mukeshpanchal27 once #1251 is fixed, I think this issue should be updated to focus only on applying a maximum constraint to left/right/center aligned images that are larger than their container. I'm also unclear about what you mean by:
Could you clarify? |
sizes
for left/right alignmentsizes
for left/right/center alignment
Any chance to support |
This is now unblocked since #1251 is fixed. |
@ramiy Could you please share more details where is use in RTL sites so we can explore it? Thanks! |
@ramiy Perhaps you're referring to supporting logical properties? So instead having to switch from |
The PR #1290 has been merged. As we are still discussing |
If we don't hear back by the end of the week, let's close the ticket. @mukeshpanchal27 |
I think the RTL issue is something to be tracked upstream in Gutenberg, for example WordPress/gutenberg#52353 Since Gutenberg doesn't use logical properties, there's nothing we can do here. |
Overview
Follow-up: #1187
This issue cover calculate
sizes
for left/right/center alignment.Approach
For initial work:
Core editor issues:
The text was updated successfully, but these errors were encountered: