Fix theme background regression. #18687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
youknowriad
reviewed
Nov 22, 2019
| @@ -1,3 +1,9 @@ | |||
| // This min-height is there to ensure the editing canvas extends at least to the full height available. | |||
| // This ensures a theme that uses a background color other than white doesn't look cropped without content. | |||
| .edit-post-visual-editor { | |||
There was a problem hiding this comment.
Should we move this to the stylesheet specific for that component https://github.com/WordPress/gutenberg/blob/master/packages/edit-post/src/components/visual-editor/style.scss#L1
youknowriad
approved these changes
Nov 22, 2019
|
It didn't occur to me that this existed, but I think I tackled the same issue in my pull request at #18732 . While the changes here are sufficient to stretch the theme background, there are also issues with clicks below the editor not directing focus to the last default block. I've included a fix for that in #18732. |
added 2 commits
November 26, 2019 09:51
This PR fixes that.
jasmussen
force-pushed
the
fix/theme-bg-issue
branch
from
2a0ee55
to
81f9eb6
Compare
|
I rebased to see if that makes the checks pass. And then I read your comment, Andrew! Please feel free to merge yours as it seems to be a better fix than this one, and I'll close this PR. 🎉 |
|
Superseded by #18732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18044 introduced a small regression where a theme with a non-white background, for example TwentyTwenty, looked cropped.
This PR fixes that by applying a min-height to the canvas.
Before:
After: