Project Management: Merge lib and REST controllers CODEOWNERS #15925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #15215
For reasons currently outside my understanding, the
*-controller.php
CODEOWNERS entry is not correctly matching. For the pull request #15651, which includes the filelib/class-wp-rest-widget-areas-controller.php
, it should have been expected that @TimothyBJacobs was assigned as reviewer by code ownership.gutenberg/.github/CODEOWNERS
Line 86 in 761543e
Reference: https://help.github.com/en/articles/about-code-owners
CODEOWNERS should prefer last-match, and follows gitignore syntax. It's possible the convention here is incorrect, though variations tested locally against
git check-ignore
don't appear to make any difference. Suggestions welcome here. I suspect it is a matter of either (a) nested directories or (b) wildcard placement.From the pull request #15651, there are also people not expected to be assigned as code owner reviewers (@noisysocks, @nerrad) based on the files changed. It may be that earlier versions of the branch included revisions to files outside this directory (it was rebased a number of times).
The text "code owners" in the screenshot:
..is linked to:
gutenberg/.github/CODEOWNERS
Line 85 in 761543e
For this reason, we can assume that at least
/lib
should be working as expected. Until this can be correctly diagnosed, @TimothyBJacobs has agreed to be included as code owner for/lib
.