Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] UI for invalid block content #15789

Merged
merged 10 commits into from
May 26, 2019
Merged

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented May 23, 2019

This PR imports to mobile the Warning and the BlockInvalidWarning components, to show a warning message on blocks with invalid content.

The Warning component was thought to be reusable, and later on reuse it with the Missing block.

IMG_1853

gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#1021

To test:

@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 23, 2019
@etoledom etoledom self-assigned this May 23, 2019
@@ -25,3 +25,5 @@ export { default as BlockEditorProvider } from './provider';
// Mobile Editor Related Components
export { default as BottomSheet } from './mobile/bottom-sheet';
export { default as Picker } from './mobile/picker';

export { default as BlockInvalidWarning } from './block-list/block-invalid-warning';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporal while we still have BlockHolder in the gutenberg-mobile side.

@etoledom etoledom requested review from koke and hypest May 23, 2019 08:04
@etoledom etoledom marked this pull request as ready for review May 23, 2019 08:04
@etoledom etoledom changed the title [MOBILE] UI for invalid block content [RNMobile] UI for invalid block content May 23, 2019
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @etoledom :highfive:

Also, as you proposed over chat, I took over the PR to bring it up to date and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants