-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] UI for invalid block content #15789
Conversation
@@ -25,3 +25,5 @@ export { default as BlockEditorProvider } from './provider'; | |||
// Mobile Editor Related Components | |||
export { default as BottomSheet } from './mobile/bottom-sheet'; | |||
export { default as Picker } from './mobile/picker'; | |||
|
|||
export { default as BlockInvalidWarning } from './block-list/block-invalid-warning'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporal while we still have BlockHolder
in the gutenberg-mobile
side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work @etoledom :highfive:
Also, as you proposed over chat, I took over the PR to bring it up to date and merge it.
This PR imports to mobile the
Warning
and theBlockInvalidWarning
components, to show a warning message on blocks with invalid content.The
Warning
component was thought to be reusable, and later on reuse it with theMissing
block.gutenberg-mobile
side PR: wordpress-mobile/gutenberg-mobile#1021To test: