-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update onSplit method on RN blocks to the latest version. #15762
Conversation
This commit updates the native richtext component to use the latest version of onSplit. It also updates the custom paragraph and heading blocks to use the new onSplit.
Code looks 👍 Testing on both android on ios (demo app)... |
Discovered a bug when merging blocks. I don't think it's related to this PR but I'd like to investigate a bit more. Here is how to reproduce (on android):
This seems to be happening because |
…etween componentWillReceiveProps and componentDidUpdate
Pushed a fix for the (seemingly unrelated) bug, feel free to test on your end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Description
This commit updates the native richtext component to use the latest version of onSplit.
It also updates the custom paragraph and heading blocks to use the new onSplit.
How has this been tested?
Use this PR on GB mobile to test: wordpress-mobile/gutenberg-mobile#1013
Screenshots
Types of changes
Checklist: