Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing file entry for util.js #15756

Merged
merged 2 commits into from
May 22, 2019
Merged

Add missing file entry for util.js #15756

merged 2 commits into from
May 22, 2019

Conversation

swissspidy
Copy link
Member

Description

Updates the files entry in package.json for the @wordpress/dependency-extraction-webpack-plugin-files package. Because of the missing entry the file is currently not included in the published release, which means it's kinda broken.

Slack discussion: https://wordpress.slack.com/archives/C02QB2JS7/p1558448690100500

How has this been tested?

Apply patch, run wp-scripts build smoothly without issues.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@swissspidy swissspidy added [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling [package] Library Export Default Webpack Plugin labels May 21, 2019
sirreal
sirreal approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, thanks 👍

packages/dependency-extraction-webpack-plugin/package.json Show resolved Hide resolved
@ntwb
Copy link
Member

ntwb commented May 21, 2019

I've added the CHANGELOG.md entry in c84b346

@gziolo gziolo merged commit 7f419f5 into master May 22, 2019
@gziolo gziolo added this to the 5.8 (Gutenberg) milestone May 22, 2019
@gziolo gziolo deleted the fix/dependency-extraction-webpack-plugin-files branch May 22, 2019 07:09
gziolo pushed a commit that referenced this pull request May 22, 2019
@swissspidy @gziolo
Add missing file entry for util.js (#15756)
ef11777 
* Add missing file entry for util.js

* Update CHANGELOG.md
This was referenced Oct 16, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

@ntwb ntwb ntwb approved these changes

@gziolo gziolo Awaiting requested review from gziolo

@aduth aduth Awaiting requested review from aduth

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
5.8 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
5 participants
@swissspidy @ntwb @gziolo @sirreal @aduth