Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Consolidate Docker commands in site installation #15742

Merged
merged 1 commit into from
May 21, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented May 20, 2019

Related: #15159

This pull request seeks to update bin/install-wordpress.sh in an effort to reduce the number of individual docker-compose commands where consolidation is straight-forward.

Each of the affected commands supports multiple arguments:

Proposed benefit: Anecdotally, each docker-compose command takes upwards of seconds to run, thus encouraging that we reduce the number in the install script. This will shorten build times for Travis and setup times for local end-to-end test runs and environment setups. Additional Docker improvements are proposed at #15159. This will likely have a more minimal impact, but is most trivial to implement.

Testing Instructions:

Verify fresh Docker environments setups for end-to-end tests (and optionally local development).

https://github.com/WordPress/gutenberg/blob/master/docs/contributors/getting-started.md#local-environment

Verify Travis build passes.

@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling [Type] Performance Related to performance efforts labels May 20, 2019
@aduth aduth requested a review from gziolo May 20, 2019 18:59
@aduth aduth mentioned this pull request May 20, 2019
14 tasks
@aduth
Copy link
Member Author

aduth commented May 20, 2019

Rough measurements:

Control: https://travis-ci.com/WordPress/gutenberg/builds/112450192
Variable: https://travis-ci.com/WordPress/gutenberg/builds/112496088

Task Before After
E2E tests (Admin with plugins) (1/4) 11 min 42 sec 11 min 14 sec
E2E tests (Admin with plugins) (2/4) 11 min 31 sec 10 min 48 sec
E2E tests (Admin with plugins) (3/4) 12 min 43 sec 12 min 56 sec
E2E tests (Admin with plugins) (4/4) 11 min 24 sec 10 min 46 sec
E2E tests (Author without plugins) (1/4) 13 min 36 sec 13 min 41 sec
E2E tests (Author without plugins) (2/4) 9 min 52 sec 8 min 39 sec
E2E tests (Author without plugins) (3/4) 12 min 1 sec 10 min 22 sec
E2E tests (Author without plugins) (4/4) 9 min 57 sec 9 min 20 sec

There's some variation within the results, but it generally looks quite positive in the range of 30-45 seconds improvement, which is perhaps more than expected (possibly other factors to consider).

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it makes sense to consolidate, good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants