-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Video block ui/ux enhancements #15551
Merged
Merged
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
00fb7d8
Pass media type to bridge
pinarol b47e8f5
Add video block
pinarol c496809
Merge branch 'master' into rnmobile/update-media-type
pinarol d29cecc
Add media upload ui
pinarol a663c30
Merge branch 'master' into rnmobile/update-media-type
pinarol 15ddaf2
Add video block
pinarol b2fe442
Extract media upload
pinarol 3d5aaa2
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 2aabed5
Fix lint issues
pinarol 44cf944
Integrate RN video
pinarol 7ab8ebd
Integrate RN video
pinarol 63868bd
Fix lint issues
pinarol db1080a
Rename MediaUploadUI
pinarol 069a701
Separate Android and iOS video player configs
pinarol 7d1047f
Fix lint issues
pinarol 9423a53
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 95278d3
Revert unwanted auto linter fix
pinarol 4307156
Update order of video block
pinarol 13fc93c
Fix typo
pinarol 49cca70
Enhance placeholder
pinarol 590d1ae
Add retry action for video block
pinarol ab37524
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 4bcc7a3
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 2a84566
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 7333b9f
Merge branch 'master' into rnmobile/video-block-first-iteration
marecar3 bffcb7f
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 1c0bc4d
Remove unused state property
pinarol aaad3b8
Merge branch 'master' into rnmobile/video-block-first-iteration
marecar3 b2fddc1
Merge branch 'master' into rnmobile/video-block-first-iteration
marecar3 e5c0313
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 226e57d
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol c046bab
Merge branch 'master' into rnmobile/video-block-first-iteration
marecar3 8d4e4c9
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 8e33850
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol c996619
Fixed problem with cancel/retry uploading of video
marecar3 862aebf
Set proper bottom sheet icons for video block
marecar3 248fce1
Make sure that icon block has latest value of isUploadingInProgress
marecar3 0e13082
Remove unnecessary code for video copy/paste handling
pinarol 3c29489
Removing poster support
pinarol c8a6fb8
Implemented latest ui-ux on video block
marecar3 5421b69
Aligned image block with video block
marecar3 922767a
Merge branch 'rnmobile/video-block-first-iteration' into rnmobile/vid…
marecar3 1a9f357
Merge branch 'master' into rnmobile/video-block-first-iteration
pinarol 66cd5dc
Merge branch 'rnmobile/video-block-first-iteration' into rnmobile/vid…
marecar3 d752797
Fixed logic on iOS when selecting video block first time, avoid to pl…
marecar3 2838fec
Merge branch 'master' into rnmobile/video-block-first-iteration
marecar3 8a2f97c
Fixed crash when opening the post which previously had cancelled imag…
marecar3 460eba2
Merge branch 'rnmobile/video-block-first-iteration' into rnmobile/vid…
marecar3 7447902
Set black background for uploaded video
marecar3 c2c97c8
Merge branch 'master' into rnmobile/video-block-first-iteration
marecar3 629810c
Merge branch 'rnmobile/video-block-first-iteration' into rnmobile/vid…
marecar3 776a9fb
Fixed retry icon color on image upload failed state
marecar3 f4435d4
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
marecar3 97e6800
Avoid loading video before it's uploaded
marecar3 af2fb2f
Fixed failed tests
marecar3 580be02
Set image background as black color with 50% alpha when image is in f…
marecar3 c216b48
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
marecar3 9a1acd2
Make sure that image/video block is selected when user taps on it
marecar3 1ec2db0
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
marecar3 7082eb1
Fixed issue with missing placeholder while image is uploading
marecar3 25aa9ca
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
marecar3 4c6d2b2
Reuse Icon function in image/video block and block picker
marecar3 27eda92
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
marecar3 4292925
Fixes issue with retry state background
marecar3 21a42c4
Fix icon crash and inject props to SVG icons
pinarol 542ae59
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
pinarol 4065516
Update video upload icon color and size, also caption padding
pinarol c4a0bd5
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
pinarol 30e98b0
Merge branch 'master' into rnmobile/video-block-ui-ux-enhancements
pinarol a5bf475
Update Icon to accept a style prop
Tug deaa780
Revert "Update Icon to accept a style prop"
pinarol 32037e8
Fix retry icon size
pinarol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { Path, SVG } from '@wordpress/components'; | ||
|
||
function svg( props ) { | ||
return <SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" { ...props }><Path d="M17.65 6.35C16.2 4.9 14.21 4 12 4c-4.42 0-7.99 3.58-7.99 8s3.57 8 7.99 8c3.73 0 6.84-2.55 7.73-6h-2.08c-.82 2.33-3.04 4-5.65 4-3.31 0-6-2.69-6-6s2.69-6 6-6c1.66 0 3.14.69 4.22 1.78L13 11h7V4l-2.35 2.35z" /><Path d="M0 0h24v24H0z" fill={ 'none' } /></SVG>; | ||
} | ||
|
||
export default svg; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { Path, SVG } from '@wordpress/components'; | ||
|
||
function svg( props ) { | ||
return <SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" { ...props }><Path d="M17.65 6.35C16.2 4.9 14.21 4 12 4c-4.42 0-7.99 3.58-7.99 8s3.57 8 7.99 8c3.73 0 6.84-2.55 7.73-6h-2.08c-.82 2.33-3.04 4-5.65 4-3.31 0-6-2.69-6-6s2.69-6 6-6c1.66 0 3.14.69 4.22 1.78L13 11h7V4l-2.35 2.35z" /><Path d="M0 0h24v24H0z" fill="none" /></SVG>; | ||
} | ||
|
||
export default svg; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tug 👋 I updated icon js files to allow injecting props. Tested with web also, don't seem to have a side effect. How does this solution look to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick test to show what it would look like and pushed here. But after discussing it with you on another channel we agreed that it would be best to handle this separately.