Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text more readable #14839

Merged
merged 2 commits into from
May 21, 2019
Merged

Make text more readable #14839

merged 2 commits into from
May 21, 2019

Conversation

yodiyo
Copy link
Contributor

@yodiyo yodiyo commented Apr 5, 2019

Description

Simple changes to make sentences more readable

How has this been tested?

Reading

Types of changes

Text and grammar changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo added [Type] Developer Documentation Documentation for developers Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Apr 5, 2019
@draganescu
Copy link
Contributor

Hi @yodiyo good work, the sentences are indeed more readable. I left some comments, let me know your thoughts.

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me, so I'm approving.

@draganescu I didn't see your comments in the file. I'll wait to merge, let me know if you have any changes needed.

Inside of this new directory, create a file called `myguten-plugin.php` which is the server-side code that runs when your plugin is active. For now place the following in that file:
The quickest way to start is to create a new directory in `wp-content/plugins/` to contain your plugin code. For this example, you can call it `myguten-plugin`.

Inside of this new directory, create a file called `myguten-plugin.php`. This is the server-side code that runs when your plugin is active.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside of this new directory -> Inside this new directory


Inside of this new directory, create a file called `myguten-plugin.php` which is the server-side code that runs when your plugin is active. For now place the following in that file:
The quickest way to start is to create a new directory in `wp-content/plugins/` to contain your plugin code. For this example, you can call it `myguten-plugin`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can call it `myguten-plugin`. -> it is not optional -> call it `myguten-plugin`.

@draganescu
Copy link
Contributor

@mkaz I just noticed the review was not submitted (facepalm). You can see them now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants