Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing Flow: Can't forward delete from empty paragraph #8731

Closed
aduth opened this issue Aug 8, 2018 · 1 comment · Fixed by #8735
Closed

Writing Flow: Can't forward delete from empty paragraph #8731

aduth opened this issue Aug 8, 2018 · 1 comment · Fixed by #8735
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Aug 8, 2018

To Reproduce

  1. Navigate to Posts > Add New
  2. Click writing prompt
  3. Press Enter
  4. Press ArrowUp
  5. Press Delete (Control + Delete on Mac) for forward deletion
  6. Observe nothing happens

Expected behavior

The next paragraph should collapse into the current.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Aug 8, 2018
@aduth aduth self-assigned this Aug 8, 2018
@aduth
Copy link
Member Author

aduth commented Aug 8, 2018

I think this is technically a regression of #8461, itself a fix of #8388.

The logic for detecting whether the horizontal edge has been reached will now consider TinyMCE's bogus br nodes and incorrectly return false, even when there is no other content in the RichText field.

@aduth aduth changed the title Writing Flow: Can't forward delete from empty block Writing Flow: Can't forward delete from empty paragraph Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant