Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reversing the Cover Image "Background Opacity" slider. #8600

Closed
kjellr opened this issue Aug 6, 2018 · 5 comments
Closed

Consider reversing the Cover Image "Background Opacity" slider. #8600

kjellr opened this issue Aug 6, 2018 · 5 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 6, 2018

Currently, if you adjust the Cover Image "Background Opacity" slider, it adjusts the opacity of the background color layer. 0% means there is no color overlay and 100% means there is a full color overlay.

cover-image-slider

In order for this to make sense, you must consider the black color to be the "background" of the cover image. I'd argue that this is confusing, and that users will consider the image to be the background, since it sits behind the text. Some informal testing of people around me has confirmed this, but I'd be interested to hear if there's more official testing one way or another.

When users consider the image to be the background, the background opacity slider values are the opposite of what you'd expect: when they're set to 0, the image is at full opacity, and when they're set to 100%, the image is invisible.

Suggested Solution

I suggest that the slider be reversed, so that 0% means the image is completely transparent (with a fully-opaque color overlay), and 100% means that the image is fully opaque (with no color overlay).

Alternatively, we should be more specific in the language of the slider to make it clear it's talking about the color, not the image.

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks Needs Decision Needs a decision to be actionable or relevant labels Aug 6, 2018
@kjellr kjellr mentioned this issue Aug 6, 2018
7 tasks
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Aug 6, 2018

I think the slider should be renamed to Background Color Opacity, and you should be able to choose the overlay color. Alternatively, it could be named Background Overlay Opacity.

I still think the Cover Image should just be a Reusable Block template consisting of a Container block with a nested Heading or Paragraph block and having preset settings.

See also:

@mtias
Copy link
Member

mtias commented Aug 24, 2018

Let's make a task for adding a background color option. Then we'd have a panel called "Overlay" which can have opacity and color as options.

@mtias mtias added Needs Design Needs design efforts. and removed Needs Decision Needs a decision to be actionable or relevant labels Aug 24, 2018
@kjellr
Copy link
Contributor Author

kjellr commented Aug 24, 2018

Let's make a task for adding a background color option. Then we'd have a panel called "Overlay" which can have opacity and color as options.

Opened #9329 and included a mockup. I suggest we keep this issue open until that's closed though. 👍

@kjellr
Copy link
Contributor Author

kjellr commented Sep 7, 2018

Removing Needs Design Label, since there's a mockup of a solution over in #9329.

@kjellr kjellr removed the Needs Design Needs design efforts. label Sep 7, 2018
@enriquesanchez
Copy link
Contributor

I believe this has already been fixed (#9329 and #10291).

Please feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants