Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication that the inserter is scrollable #776

Closed
emcarru opened this issue May 12, 2017 · 8 comments · Fixed by #996
Closed

No indication that the inserter is scrollable #776

emcarru opened this issue May 12, 2017 · 8 comments · Fixed by #996
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.

Comments

@emcarru
Copy link

emcarru commented May 12, 2017

I only discovered that the inserter is scrollable by chance, because I was tabbing through the options. I would suggest that the scrollbar is always visible, or at least there is some other indication that the user can scroll down in this box:
inserter

@aduth
Copy link
Member

aduth commented May 12, 2017

Can you clarify which browser and operating system (including versions) you use?

Wondering if this might be default MacOS behavior of hiding scrollbars. I force them to always be visible and see the inserter as scrollable:

image

@emcarru
Copy link
Author

emcarru commented May 12, 2017

Yes sorry! You are correct, I'm on a mac (latest OS), and I would also assume this is the default behaviour, as I have not set them to always be visible (but I am now changing that!).

@aduth
Copy link
Member

aduth commented May 12, 2017

Okay, in which case I'd say this can be closed as expected operating system behavior. The only other option would be to create a custom scrollbar, but this tends to be fraught with all sorts of challenges and probably not necessary for what we want here (cc @jasmussen just in case).

@aduth aduth closed this as completed May 12, 2017
@aduth
Copy link
Member

aduth commented May 12, 2017

In the prototypes there's also a "shadow" effect at the bottom of the panel to indicate that there's more to see. We probably want that in the plugin as well, and could help discoverability here.

Related: #98

Maybe we can reopen this one or #98 and repurpose as the task for implementing this?

@jasmussen
Copy link
Contributor

I think it's a fair point.

Noting that it's an issue only on Macs, where the scrollbars fade out. And yes, the shadow is meant to indicate that there's more content, however I can see how that might not be enough.

Since we also have #656 (scroll bleed) to worry about, perhaps we can group a bunch of tasks together into one that I can take care of? That would be:

  • Make scroll indicator shadow more visible
  • Perhaps show scrollbar all the time, and at the same time fix scroll bleed by using this trick https://codepen.io/joen/pen/wGbBoe

Thoughts?

@jasmussen
Copy link
Contributor

Reopening.

@jasmussen jasmussen reopened this May 16, 2017
@jasmussen jasmussen added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. labels May 16, 2017
@jasmussen jasmussen self-assigned this May 16, 2017
@aduth
Copy link
Member

aduth commented May 16, 2017

Perhaps show scrollbar all the time

Can you clarify what you mean by this @jasmussen ?

@jasmussen
Copy link
Contributor

Can you clarify what you mean by this @jasmussen ?

Yes. Since the autohiding fancy scrollbars are a Mac only thing, perhaps we can use the ::-webkit-scrollbar CSS styles to style them, like in that codepen. They'll look exactly like native scrollbars, but they'll essentially be custom ones. Incidentally this forces the scrollbars present, even when MacOS sets them to being off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants