Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Block: reordering images, including support for Drag&Drop #743

Closed
mkaz opened this issue May 9, 2017 · 13 comments
Closed

Gallery Block: reordering images, including support for Drag&Drop #743

mkaz opened this issue May 9, 2017 · 13 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.x

Comments

@mkaz
Copy link
Member

mkaz commented May 9, 2017 •
edited by oandregal
Loading

Related #317 and #740

Tasks tracking:
@jasmussen jasmussen added the [Feature] Blocks Overall functionality of blocks label May 10, 2017
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label May 16, 2017
@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Jun 29, 2017
@jasmussen jasmussen added this to the Beta 0.8.0 milestone Jul 5, 2017
@mtias mtias modified the milestones: Beta 0.5.0, Beta 0.8.0, Beta 0.6.0 Jul 6, 2017
@mtias mtias modified the milestones: Beta 0.7.0, Beta 0.6.0 Jul 28, 2017
@karmatosed karmatosed added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Aug 3, 2017
@mtias mtias modified the milestones: Beta 0.7.0, Beta, Nice To Have Aug 4, 2017
@mtias mtias mentioned this issue Aug 4, 2017
Closed
@youknowriad youknowriad mentioned this issue Sep 4, 2017
Merged
@StaggerLeee
Copy link

Just played with Gutenberg and realized it would be one killer new addition.
If it is demanding to do from coding viewpoint just say it. You all have much to do right now, we know.

@mtias mtias mentioned this issue Nov 20, 2017
Closed
This was referenced Dec 17, 2017
Closed
Merged
@paulwilde paulwilde mentioned this issue Jan 23, 2018
Closed
3 tasks
@mtias mtias removed the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Jan 26, 2018
@caxco93 caxco93 mentioned this issue Jul 18, 2018
Closed
4 tasks
@kjellr kjellr mentioned this issue Jul 30, 2018
Closed
12 tasks
@oandregal oandregal added the [Feature] Drag and Drop Drag and drop functionality when working with blocks label Sep 12, 2018
@caxco93 caxco93 mentioned this issue Sep 17, 2018
Closed
4 tasks
@mtias mtias removed the Future label Oct 7, 2018
@youknowriad youknowriad removed the Future label Jan 9, 2019
@tbradsha tbradsha mentioned this issue Jan 17, 2019
Closed
@oandregal oandregal mentioned this issue Feb 13, 2019
Closed
@janeschindler
Copy link

I can drag and drop images in a gutenberg gallery, but they don't always appear in the order I dragged them to. This seems buggy to me. Does anyone else have that experience?

@oandregal
Copy link
Member

I'll start working on this.

@oandregal oandregal self-assigned this Mar 28, 2019
@oandregal oandregal mentioned this issue Apr 2, 2019
Merged
@oandregal
Copy link
Member

#14768 adds the basic mechanics for moving the selected image forward/backward - also visual controls. I consider that the first step for this task.

@oandregal
Copy link
Member

Added a task list in the issue description to track ongoing work and the status of this.

@oandregal oandregal changed the title Gallery Block: Drag and Drop Ordering Gallery Block: reordering images, including Drag & Drop support Apr 4, 2019
@oandregal oandregal changed the title Gallery Block: reordering images, including Drag & Drop support Gallery Block: reordering images, including support for Drag&Drop Apr 4, 2019
@oandregal oandregal mentioned this issue Apr 26, 2019
Closed
@oandregal
Copy link
Member

#15222 adds drag&drop mechanics.

@oandregal
Copy link
Member

Second attempt to fix gallery tab order can be reviewed at #15540

@noisysocks noisysocks added the [Status] In Progress Tracking issues with work in progress label Jul 10, 2019
@AnthonyLedesma AnthonyLedesma mentioned this issue Aug 22, 2019
Closed
@noisysocks noisysocks removed the [Status] In Progress Tracking issues with work in progress label Aug 29, 2019
@noisysocks
Copy link
Member

I've been thinking it would make more sense to rewrite the Gallery block so that it is a container block (using <InnerBlocks>) that contains one or more Image blocks.

Doing this would mean that we get drag and drop for free, and that the UI for moving images within a gallery would match the UI for moving blocks within a Group block, or Column blocks within a Columns block, or Navigation Menu Item blocks within a Navigation Menu block.

Related: #16974

@caxco93
Copy link
Contributor

caxco93 commented Oct 24, 2019

@noisysocks I might be able to try that out soon. thanks for the tip

@Soean Soean added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Dec 6, 2019
@oandregal oandregal removed their assignment Jan 22, 2020
@mapk
Copy link
Contributor

mapk commented Apr 6, 2020

@mkaz it looks like most everything is crossed off in the issue description. Can we close this?

@oandregal
Copy link
Member

It actually was me that created that list when I took over the issue from Marcus :)

I'm fine closing this. However, my question would be if we want to track somewhere adding Drag&Drop support for the image gallery?

@noisysocks
Copy link
Member

I think adding drag and drop to the Gallery block as it currently exists is a wasted effort. Better to have Gallery use <InnerBlocks /> and get it for "free". We could open an issue which tracks this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests