Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover image provides no indicator where to click for adding text #6823

Closed
maddisondesigns opened this issue May 18, 2018 · 5 comments
Closed
Labels
[Feature] Blocks Overall functionality of blocks [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@maddisondesigns
Copy link

Describe the bug
After adding a Cover Image block it displays a tiny toolbar on top of the image, however there's no indicator or even a flashing cursor, to show where you're actually supposed to click to insert text, or even that you can actually insert text.

This is just one of the many blocks that are incredibly frustrating to use because of the poor UI and lack of visual indicators!

To Reproduce
Steps to reproduce the behaviour:

  1. Add a cover image
  2. Try and work out where you have to click to add text

Expected behaviour
I shouldn't have top spend 5 minutes clicking around on the image to try and find the insertion point so that I can add some text

Screenshots
gutenberg_coverimagenoclickindicator

macOS Sierra 10.12.1 (16B2659)
Firefox Quantum 60.0 (64-bit)
WordPress 4.9.6
Gutenberg 2.8.0

@maddisondesigns maddisondesigns changed the title Cover image provides no idicator where to click for adding text Cover image provides no indicator where to click for adding text May 18, 2018
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented May 18, 2018

This issue will likely be resolved by a combination of the Cover Image and Quote blocks being updated to use nested blocks (#5452 and #6520) and block hover UI improvements (#6773).

@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels May 18, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 18, 2018
@danielbachhuber
Copy link
Member

This issue will likely be resolved by a combination of the Cover Image and Quote blocks being updated to use nested blocks

Cool. Let's keep this issue open until we can confirm the problem is addressed.

@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Jul 19, 2018
@johngodley
Copy link
Contributor

Circling back on this, the current cover image block behaviour is that it now shows a placeholder indicating there's a clickable part:

edit_post_ wordpress_latest _wordpress

The toolbar only appears when clicked:

edit_post_ wordpress_latest _wordpress

I think this resolves the original issue?

@maddisondesigns
Copy link
Author

@johngodley That's working better now that there's placeholder text.

@johngodley
Copy link
Contributor

Great, thanks. Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants