Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Inserter: Multiple undo histories are created #63479

Closed
t-hamano opened this issue Jul 12, 2024 · 2 comments · Fixed by #63215
Closed

Pattern Inserter: Multiple undo histories are created #63479

t-hamano opened this issue Jul 12, 2024 · 2 comments · Fixed by #63215
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jul 12, 2024

Description

When I insert a pattern, multiple undo histories are created, so I cannot delete a pattern unless I press the Undo button several times after inserting it. The amount of history created depends on the pattern inserted.

I looked back through the commit history and it looks like this issue first appeared in #61915.

Step-by-step reproduction instructions

After inserting a pattern, click the Undo button.

Screenshots, screen recording, code snippet

Before #61915

before.mp4

After #61915

after.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 12, 2024
@Mamaduka
Copy link
Member

@t-hamano, the source PR for the bug seems incorrect. It's also the same PR that should fix it.

@t-hamano
Copy link
Contributor Author

@Mamaduka Thanks for pointing that out! I've corrected the PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants