-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordPress 6.6 RC3 and Query Loop block issue (When WooCommerce is active) #63448
Comments
@sergiu-radu Thanks for reporting this. Out of interest, have you also flagged this bug with WooCommerce? The plugin seems to change the way the mobile/tablet/desktop views work quite significantly. The views seem to completely 'reload', whereas you compare it to when WooCommerce is deactivated and there's a smooth animation between mobile and desktop. That's part of the reason the bug happens. However, with the Gutenberg plugin active the bug doesn't happen, so it makes it a little hard to repro/fix. Anyway, the main cause is the grid visualizer for some reason that the post template block has (the grey outlines of the columns). It uses a I think there's some extra safety that can be added to our |
Hello @talldan, thank you very much for replying to this and for the detailed explanation.
I know that WooCommerce is changing the viewport by removing the Anyway, I hope you will be able to find a solution and include it in the 6.6 release. Thank you and have a wonderful day! |
Unfortunately it's too late now for WordPress 6.6, but potentially a 6.6.1. |
Hey @talldan, I understand, thanks for letting me know. |
This is the error message btw:
|
Here's some more detail about where the bug happens. The Gutenberg Popover component calls gutenberg/packages/components/src/popover/index.tsx Lines 289 to 292 in 2ce7497
When the bug happens, the Floating UI calls This is where things start to go wrong, that function calls Then finally because Jumping back to I think floating ui could have some checks for whether a node is connected somewhere in there, but then they may also consider the idea of calling |
My steps to reproduce:
This happens with The root cause is the If you have a variable that points on an element that's inside an iframe that has been already deleted, it has some funny properties. FYI @ellatrix because |
Hello @sergiu-radu 👋 I'm gathering the list of contributors who contributed to 6.6.1 (i.e. for giving each person credit). I'm not able to locate your WordPress profile. Maybe your GitHub profile is not linked to it or you don't yet have a WordPress profile. Can you please share your profile username or the Thank you for contributing and following up with me. |
Hello @hellofromtonya, Here it is - https://profiles.wordpress.org/creativethemeshq/ |
@sergiu-radu, Thank you. Contribution prop / credit is given for a person, not a company. Can you please create a WP profile for yourself and then link it to your GitHub username / profile? Some examples: You can create it using the same GitHub username |
Description
When switching to tablet mode and back to desktop mode while the "Post Template" block is selected - the block breaks.
This seems to be somehow related to WooCommerce plugin.
Here is a quick view demonstration:
https://github.com/WordPress/gutenberg/assets/8998558/5d0bdd93-f7af-4293-b3c0-638e0a930941
Everything works fine if WooCommerce is deactivated.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: