Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout alignment issue due to global padding on wide blocks (WP 6.6 RC1) #63008

Closed
YanCol opened this issue Jul 1, 2024 · 5 comments · Fixed by #63207
Closed

Layout alignment issue due to global padding on wide blocks (WP 6.6 RC1) #63008

YanCol opened this issue Jul 1, 2024 · 5 comments · Fixed by #63207
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Bug An existing feature does not function as intended

Comments

@YanCol
Copy link

YanCol commented Jul 1, 2024

Description

Since the implementation of #60715, “Padding is applied to all blocks with constrained layout that are full width or wide width.”

This change has introduced layout issues where the content no longer aligns as expected.

See the screenshots below for examples with the Twenty Twenty-Four theme and a WordPress.com theme.

Step-by-step reproduction instructions

Steps to reproduce:

  1. Visit https://2024.wordpress.net/index.php/entrepreneur-demo (which showcases the Blog Home template of the default theme)
  2. Scroll to the third section "An array of resources" and fifth section "Watch, Read, Listen"
  3. Observe that the content isn’t correctly aligned

Screenshots, screen recording, code snippet

https://2024.wordpress.net/index.php/entrepreneur-demo/

WordPress 6.5 WordPress 6.6 RC1
2024-before 2024-after

https://greensteaddemo.wordpress.com/

WordPress 6.5 WordPress 6.6 RC1
WordPresscom-before WordPresscom-after

Environment info

WordPress 6.6 RC1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@YanCol YanCol added the [Type] Bug An existing feature does not function as intended label Jul 1, 2024
@skorasaurus skorasaurus added the [Feature] Layout Layout block support, its UI controls, and style output. label Jul 1, 2024
@andrewserong
Copy link
Contributor

@tellthemachines and @richtabor just an FYI about this one. Does this sound like a bug in the recently shipped rules changes, or do themes need to update how they construct their patterns? In this case since it might affect content out in the wild, I wasn't sure the scope of the issue.

@tellthemachines
Copy link
Contributor

I believe it was a deliberate decision but might be good to confirm with @richtabor because it's hard to anticipate the exact effects of these rules, so this could have been an unintended consequence.

@annezazu
Copy link
Contributor

annezazu commented Jul 2, 2024

Adding to 6.6 board to be safe either way.

@carolinan
Copy link
Contributor

What exactly do theme developers need to change in order to make their layout work in multiple WordPress versions?
The minimum required WordPress versions of the bundled themes can't be adjusted.

@richtabor richtabor mentioned this issue Jul 5, 2024
Merged
@richtabor
Copy link
Member

What exactly do theme developers need to change in order to make their layout work in multiple WordPress versions?
The minimum required WordPress versions of the bundled themes can't be adjusted.

Nothing. 🙂 #63207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Bug An existing feature does not function as intended
Projects
WordPress 6.6 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include alignwide in nested has-outer-padding logic WordPress/gutenberg
7 participants
@skorasaurus @richtabor @carolinan @tellthemachines @andrewserong @annezazu @YanCol