Description

The 'Remove shadow' icon buttons in the Global Styles are unlabeled.

More accurately, propr to the button are passed via an object, where an ariaLabel and a tooltip keys are set.
However, the Button component either accepts a label prop or an aria-label attribute.
Not sure why the tooltip prop passed this way doesn't work btut, regardless, it's unnecessary if the label prop is set correctly.

The rendered markup is invalid as the key names are rendered as HTML attributes:

• the button element has an arialabel attribute, it should be aria-label
• the button element has an tooltip attribute

Screenshot of the button markup in the dev tools inspector and the accessibility tab selected to show the button doesn't have an accessible name:

I'm not sure why those props are passed via an object in the first place, instead of being passed individually to the Button component. As far as I can tell there's no need to set a variable for that object in the first place.

I have to note this is one more occurrence of an unlabeled control in the editor. There have been dozens of cases because contributors to this project keep 'doing it wrong' and the base component are open to misuesd.

As pointed out in several other issues and conversations, unlabeled controls are not acceptable. The only way to make sure this doesn't happen again is by refactoring the base components and make the label prop required. See #51740

Cc @WordPress/gutenberg-components

Step-by-step reproduction instructions

• Go to the Site Editor > Styles > Shadows > click one of the default shadows > click the plus icon button 'Add shadow'.
• A new shadow item will appear in the list below, with a minus icon button. Screenshot:

• Hover or focus the minus icon button.
• Observe no tooltip appears.
• Inspect the source and observe the button has an arialabel attribute instead of aria-label.
• Observe there's also a tooltip attribute.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes