Site Editor Sidebar: Hide horizontal scrollbar when navigating #63194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
This issue is very noticeable on Windows OS and Chrome. Hopefully it will be backported to WP6.6 RC3. |
|
Size Change: +285 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
the
Backport to WP 6.6 Beta/RC
jsnajdr
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Nice catch! It's a regression I introduced in #60466. Before that, the overflow-x style would come from Emotion:
These Emotion styles are defined as styles.navigatorProviderWrapper here: https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/navigator/styles.ts#L6-L14
But after my PR the NavigatorProvider is no longer used, so these CSS properties are missing.
To fully fix the regression, you should also add the contain: content property.
|
Thanks for the review!
I added |
|
Thanks! Now the fix should be complete. |
github-actions
bot
removed
the
Backport to WP 6.6 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Site Editor Sidebar: Hide horizontal scrollbar when navigating * Add `contain: content` and comment Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 63641d5 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…ress#63194) * Site Editor Sidebar: Hide horizontal scrollbar when navigating * Add `contain: content` and comment Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63192
What?
This PR hides the horizontal scrollbar that appears when navigating in the site editor sidebar.
How?
To be honest, I didn't know the root cause. Maybe it's related to animations when navigating.
The only solution I found was to apply
overflow-x: hidden;to the sidebar content.Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4