Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter overflows when open on mobile #5721

Closed
noisysocks opened this issue Mar 21, 2018 · 3 comments
Closed

Inserter overflows when open on mobile #5721

noisysocks opened this issue Mar 21, 2018 · 3 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Milestone
Merge: Editor

Comments

@noisysocks
Copy link
Member

Issue Overview

When opening the inserter on a mobile device, the inserter appears too wide and overflows past the edge of the screen.

Steps to Reproduce (for bugs)

  1. Using DevTools, turn on mobile device emulation (I selected iPhone 6/7/8)
  2. Open the inserter

Expected Behavior

The inserter should appear and fill the screen.

Current Behavior

The inserter appears but is too wide for the screen.

Screenshots / Video

screen shot 2018-03-21 at 16 38 45

Related Issues and/or PRs

This seems to have been introduced by #5541.
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface Mobile Web Viewport sizes for mobile and tablet devices labels Mar 21, 2018
@karmatosed
Copy link
Member

Good find! Hopefully we can get a fix as that's not great.

@karmatosed karmatosed added this to the Merge Proposal milestone Mar 24, 2018
@jorgefilipecosta
Copy link
Member

Hi @noisysocks in my tests this problem seems fixed. Could you confirm if that's case or if the problem is still persisting in your tests?

@noisysocks
Copy link
Member Author

Yep, this seems fine now! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Merge: Editor
Development

No branches or pull requests
3 participants
@karmatosed @noisysocks @jorgefilipecosta