Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items cannot be selected when the overlay menu is expanded. #51330

Closed
torounit opened this issue Jun 8, 2023 · 4 comments
Closed

Menu items cannot be selected when the overlay menu is expanded. #51330

torounit opened this issue Jun 8, 2023 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@torounit
Copy link
Member

torounit commented Jun 8, 2023

Description

In the editor, when the navigation is expanded, the navigation block cannot be selected if the focus moves to anything other than the navigation.

This is caused by useDisabled setting the inert attribute to wp-block-navigation__responsive-container is-menu-open. IMO.

Once in this state, it becomes difficult to close the overlay menu, and you can't touch the navigation unless you select the navigation block again from the list view.

It is more likely to occur when the overlay menu is set to Always, but it also occurs when the menu is set to Mobile.

Step-by-step reproduction instructions

  1. Go to site editor.
  2. Go to Navigation block setting.
  3. Set Always to OVERLAY MENU.
  4. Open overlay menu in editor.
  5. Click on a non-menu item.

Screenshots, screen recording, code snippet

2023-06-08.20.25.23.mov

Environment info

  • Gutenberg 16 or WordPress 6.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@torounit torounit added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jun 8, 2023
@ghorivipul97
Copy link
Contributor

Hello @torounit
assign issues to me.
I will start to work on it

@ndiego
Copy link
Member

ndiego commented Jul 17, 2023

Hi @ghorivipul97 are you still working on this?

@annezazu
Copy link
Contributor

I wasn't able to replicate this problem with RC 2. @torounit can you replicate and/or provide more information? In my case, I found that I couldn't select other blocks outside of the navigation block when the overlay was active:

Screen.Recording.2023-07-24.at.10.02.05.AM.mov

@torounit
Copy link
Member Author

@annezazu
I tried a little with WP 6.3-RC2 and this issue seems to be resolved.

Perhaps it was fixed by #51378.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
Development

No branches or pull requests

4 participants