Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation on Browse Mode: Remove existing editing functionality #50698

Closed
3 tasks done
scruffian opened this issue May 17, 2023 · 5 comments
Closed
3 tasks done

Navigation on Browse Mode: Remove existing editing functionality #50698

scruffian opened this issue May 17, 2023 · 5 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@scruffian
Copy link
Contributor

scruffian commented May 17, 2023

As part of #50396, the first step is to remove some of the existing functionality from the Navigation List View in Browse Mode, specifically:

  • Remove the link control popup for custom links and unset links.
  • Remove add submenu option.
  • Move the behaviour that selects a page to the ellipsis menu
@scruffian scruffian added [Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 17, 2023
@scruffian scruffian changed the title Navigation on Browse Mode Navigation on Browse Mode: Remove existing editing functionality May 17, 2023
@getdave getdave self-assigned this May 19, 2023
@getdave getdave added the [Status] In Progress Tracking issues with work in progress label May 19, 2023
@getdave
Copy link
Contributor

getdave commented May 19, 2023

Working on this now

@getdave
Copy link
Contributor

getdave commented May 19, 2023

I have a PR in #50788 which removes the main edit pieces.

Move the behaviour that selects a page to the ellipsis menu

This part is not clear to me. If understand that if you click on a menu item it will currently go to a preview of that page in the Browse Mode. I understand we want to remove that functionality but if we do then what happens if you select a Nav item? Nothing? The issue is that it still needs to be selectable to allow for drag & drop so this feels unusual.

@jasmussen
Copy link
Contributor

Just catching up here. I understand that we may be removing the “click to navigate to page” action from the navigation items. For context, initial efforts had the Navigation section act as both content access and basic menu management. With the recent addition of the Pages section, this is less necessary, and if we remove the drilldown from these items we also simplify some of the back button behavior.

I still think there can be value in the drilldowns in the navigation section, especially as each drilldown detail increases in value (such as clicking the blog, then changing posts per page), but it is also fine to omit this behavior if it simplifies the process going forward. We can always revisit.

@scruffian
Copy link
Contributor Author

PR to move the navigate action to the ellipsis menu here: #50843

@scruffian
Copy link
Contributor Author

This has been done.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Development

No branches or pull requests

4 participants