Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display home / loop icon on the relevant page details view #50582

Closed
Tracked by #33094
mtias opened this issue May 12, 2023 · 6 comments
Closed
Tracked by #33094

Display home / loop icon on the relevant page details view #50582

mtias opened this issue May 12, 2023 · 6 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented May 12, 2023

In the Pages panel, the homepage and posts page are indicated via icons so that you can quickly find / edit them:

Screenshot 2023-06-07 at 18 46 24

It would be good to find a way to carry this through to the page details panel too. Appending the same icon seems like a reasonable place to start:

Screenshot 2023-06-07 at 18 49 55

Issue updated June 7.

Initial version Screenshot 2023-05-05 at 16 04 00
@mtias mtias mentioned this issue May 12, 2023
57 tasks
@jameskoster
Copy link
Contributor

One thing to be cautious about is making the icon look like a button given it's proximity to the Edit button. In the future it might serve as a shortcut to homepage settings, but until then we could try different placement / color. Or both:

Screenshot 2023-05-12 at 13 00 04

I'm not sure we really need the tooltip but it's an option to consider.

We can apply the same format on the Pages list too:

Screenshot 2023-05-12 at 13 02 34

if the home page is the Blog

A small note on this point, when the homepage is the blog, there is no associated page. There's just the Home / Index template. We should still show the icon on the relevant template:

Screenshot 2023-05-12 at 13 05 14

But it could also be good to include a proxy for that template in the Pages list too – though that's one to tackle separately.

@annezazu annezazu added Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 15, 2023
@jasmussen
Copy link
Contributor

Nice work, Jay, that feels close enough that we can get started.

Just to try another thing, reintroducing icons in the pages lists that would help too:

Site Structure, Page

The above also puts the home icon left of the title, and pretty close to it, and white. I realize we have lots of icons here, but there's just something about keeping it white that appeals to me. Not a strong opinion though. Figma.

👆 The metrics and colors are off in this sketch, though, so take it mainly as placement notes. What do you think?

@jasmussen jasmussen added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels May 16, 2023
@jameskoster
Copy link
Contributor

Agreed, the icon work in the Pages panel is underway in #50630 🚀

@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels May 22, 2023
@jasmussen
Copy link
Contributor

I tentatively went ahead and updated this one. It's such as small thing.

@jameskoster
Copy link
Contributor

I think the changes are already included in the PR 🚀

@jasmussen jasmussen added [Status] In Progress Tracking issues with work in progress and removed Needs Dev Ready for, and needs developer efforts labels May 22, 2023
@jameskoster jameskoster changed the title Display home icon on the relevant template & page details view Display home / loop icon on the relevant page details view Jun 7, 2023
@jameskoster
Copy link
Contributor

Updated this issue given the Pages panel now indicates the home / posts page.

@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jun 26, 2023
@mtias mtias closed this as completed Jun 28, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

6 participants