Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micro delay to "Save Draft" button #4644

Closed
danielbachhuber opened this issue Jan 23, 2018 · 7 comments
Closed

Add micro delay to "Save Draft" button #4644

danielbachhuber opened this issue Jan 23, 2018 · 7 comments
Labels
[Feature] Saving Related to saving functionality [Type] Enhancement A suggestion for improvement.

Comments

@danielbachhuber
Copy link
Member

To improve the perceived UX of the "Save Draft" button, it would be helpful to add a micro delay to the transition:

Also, the "Save Draft" button switches really fast from "Saving" to "Saved". As a user, I might not notice that at all ("did I really just save?") or it can feel buggy ("this was way too fast"). Adding a little delay might help here.

From #1295 (comment)

@danielbachhuber danielbachhuber added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jan 23, 2018
@karmatosed
Copy link
Member

If we are adding a delay just to inform the user wouldn't working on messages help? I would suggest that from a design perspective for a critical feature like saving adding in delays could be not the best approach, or at least something to do after we look at the flow and how we can improve.

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Jan 23, 2018
@danielbachhuber
Copy link
Member Author

I would suggest that from a design perspective for a critical feature like saving adding in delays could be not the best approach

There's some existing prior art for this in WordPress core but I can't remember the component.

at least something to do after we look at the flow and how we can improve.

Yes, worth revisiting the entire flow.

@karmatosed
Copy link
Member

There's some existing prior art for this in WordPress core but I can't remember the component.

Would be great to dig into that a bit and add context.

@karmatosed karmatosed removed the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 25, 2018
@karmatosed
Copy link
Member

@danielbachhuber did you find the prior art on this?

@danielbachhuber
Copy link
Member Author

I've looked twice now but can't find what I'm thinking of.

@azaozz Do you recall what I'm referring to, or do I have a false memory?

I would suggest that from a design perspective for a critical feature like saving adding in delays could be not the best approach

There's some existing prior art for this in WordPress core but I can't remember the component.

@azaozz
Copy link
Contributor

azaozz commented Mar 11, 2018

Do you recall what I'm referring to

Perhaps you mean the delay/disabling of the Save Draft button after clicking it to prevent double clicks and doing two identical requests? That's a standard UI feature that is needed everywhere :)

With the addition of autosaves end point in the REST API, thinking the UI for saving drafts will need to change a bit. What I mean is the user should be able to save a draft at any point, but the editor will do autosaving on an interval (when there are changes).

The difference is when the user saves a draft "manually", they also create a revision, autosaves don't create revisions, just update the post directly or may update the autosave revision if the post author is different than the current user.

Also the client (i.e. Gutenberg) should probably do a "full save" for drafts from time to time instead of an autosave. This is a "weakness" in the classic editor/Edit Post screen; it would replace the whole post on autosaves and never create a draft, no matter what. However if the user did something by mistake, it will save that mistake with no way to recover from it.

@danielbachhuber
Copy link
Member Author

Closing as maybelater. There's ongoing work to the save / autosave UX right now. I don't think this particular approach needs to be adopted as long as the UX improves generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants