Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Overlay: Add option to replace close icon #42848

Closed
mikachan opened this issue Aug 1, 2022 · 0 comments · Fixed by #43067
Closed

Navigation Overlay: Add option to replace close icon #42848

mikachan opened this issue Aug 1, 2022 · 0 comments · Fixed by #43067
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@mikachan
Copy link
Member

mikachan commented Aug 1, 2022

What problem does this address?

In #36149, we added the option to replace the overlay menu icon with text. However, when the overlay is open, we still use an icon for closing the overlay.

image

What is your proposed solution?

It would be nice to also replace the close icon with text as well (probably 'close'), as part of the hasIcon toggle. Or, we could have a separate option just for the close button.

@mikachan mikachan added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Aug 1, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 8, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants