Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should copy/paste partial selection with other blocks in-between #40307

Closed
github-actions bot opened this issue Apr 13, 2022 · 7 comments · Fixed by #40607
Closed

[Flaky Test] should copy/paste partial selection with other blocks in-between #40307

github-actions bot opened this issue Apr 13, 2022 · 7 comments · Fixed by #40607
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Apr 13, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should copy/paste partial selection with other blocks in-between

Test path

/test/e2e/specs/editor/various/copy-cut-paste.spec.js

Errors

[2022-04-13T10:53:37.816Z] Test passed after 1 failed attempt on fix/gutenberg-7422.
[2022-05-10T15:54:12.212Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-10T18:58:48.443Z] Test passed after 1 failed attempt on fix/input-field-reset-behavior-moar.
[2022-05-16T07:50:54.794Z] Test passed after 1 failed attempt on refactor/range-control-to-typescript.
[2022-05-16T09:51:44.019Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-17T12:40:34.532Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-17T12:57:59.053Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-20T11:35:14.253Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-20T13:18:45.638Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-20T13:47:09.850Z] Test passed after 1 failed attempt on wp/6.0.
[2022-05-23T11:13:58.099Z] Test passed after 1 failed attempt on wp/6.0.
[2022-06-21T14:02:55.204Z] Test passed after 1 failed attempt on wp/6.0.
[2022-06-21T14:19:11.355Z] Test passed after 1 failed attempt on wp/6.0.
[2022-06-21T14:28:33.011Z] Test passed after 1 failed attempt on wp/6.0.
[2022-06-30T14:24:58.413Z] Test passed after 1 failed attempt on wp/6.0.
[2022-06-30T14:54:04.511Z] Test passed after 1 failed attempt on wp/6.0.
[2022-07-05T12:10:46.496Z] Test passed after 1 failed attempt on wp/6.0.
[2022-07-05T12:18:46.739Z] Test passed after 1 failed attempt on wp/6.0.
[2022-07-20T09:28:48.803Z] Test passed after 1 failed attempt on fix/backport-variations-schema-to-6.0.
[2022-10-17T15:04:04.101Z] Test passed after 1 failed attempt on wp/6.0.
[2022-10-17T15:35:47.239Z] Test passed after 1 failed attempt on grouped-603/wp/6.0.
[2022-10-17T15:39:16.256Z] Test passed after 1 failed attempt on wp/6.0.
[2022-10-17T15:51:04.103Z] Test passed after 1 failed attempt on wp/6.0.
[2023-02-27T18:35:22.199Z] Test passed after 2 failed attempts on try/something.
[2023-10-04T13:48:30.334Z] Test passed after 1 failed attempt on try/debounce-rich-text-on-input.
Error: Snapshot comparison failed:

  <!-- wp:paragraph -->
  <p>A block</p>
  <!-- /wp:paragraph -->

  <!-- wp:spacer -->
  <div style="height:100px" aria-hidden="true" class="wp-block-spacer"></div>
  <!-- /wp:spacer -->

  <!-- wp:paragraph -->
  <p>B block</p>
  <!-- /wp:paragraph -->

Expected: /home/runner/work/gutenberg/gutenberg/artifacts/test-results/editor-various-copy-cut-paste-Copy-cut-paste-s-3bb90--partial-selection-with-other-blocks-in-between-chromium/Copy-cut-paste-should-copy-paste-partial-selection-with-other-blocks-in-between-1-expected.txt
Received: /home/runner/work/gutenberg/gutenberg/artifacts/test-results/editor-various-copy-cut-paste-Copy-cut-paste-s-3bb90--partial-selection-with-other-blocks-in-between-chromium/Copy-cut-paste-should-copy-paste-partial-selection-with-other-blocks-in-between-1-actual.txt
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/copy-cut-paste.spec.js:282:49
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Apr 13, 2022
@kevin940726
Copy link
Member

Hi, @ntsekouras 👋. Seems like the test is pretty flaky since introduced in #40098. Do you know what might have gone wrong here?

@ntsekouras
Copy link
Contributor

I'm wondering if it's related to #39807. Locally I cannot reproduce and both flaky tests seem to fail only once and then always pass.

I could see that in the migrated util there were changes like here that didn't match the previous util function and we have an clipboardDataHolder object that is being used/shared on copy/cut/paste actions and is being mutated. I'm not sure if there is a connection, but it feels weird and needs more looking.

In general a snapshot like this:

<!-- wp:paragraph -->
  <p>A undefinedundefinedundefinedblockundefinedundefinedundefined</p>
  <!-- /wp:paragraph -->

seems really weird and makes me think there is something wrong in our custom emulateClipboard function.. I haven't pinpointed the reason yet.

@kevin940726
Copy link
Member

kevin940726 commented Apr 25, 2022

The undefined keyword was a bug and was fixed in #40384 (unrelated to the test itself).

As for the clipboardData question, I answered it in the original PR :).

@kevin940726
Copy link
Member

The debug artifacts aren't that helpful since traces are not recorded for the first failure 😅. I proposed a PR in #40586 to change that.

@kevin940726
Copy link
Member

It's probably reopened because of some outdated branch. Let's close it again.

@github-actions github-actions bot reopened this Apr 27, 2022
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 25, 2022
@github-actions github-actions bot reopened this Oct 17, 2022
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 18, 2022
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 18, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2022
@github-actions github-actions bot reopened this Feb 27, 2023
@github-actions github-actions bot mentioned this issue Feb 27, 2023
@Mamaduka Mamaduka closed this as completed Mar 2, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
@github-actions github-actions bot reopened this Oct 4, 2023
@Mamaduka Mamaduka removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants