Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Palette item is missing hover and selected states #37832

Closed
javierarce opened this issue Jan 10, 2022 · 1 comment · Fixed by #37962
Closed

Palette item is missing hover and selected states #37832

javierarce opened this issue Jan 10, 2022 · 1 comment · Fixed by #37962
Assignees
@jorgefilipecosta
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@javierarce
Copy link
Contributor

javierarce commented Jan 10, 2022 •
edited
Loading

Description

The palette items used to showcase and edit colors in the Global Styles section lack two important UI indicators: the hover and the selected states. This makes it difficult to see what element is being edited.

theme.mp4
theme_2.mp4

Also notice that in the second video, the cursor only changes when the user hovers the text, making it difficult to see that the item is editable.

Step-by-step reproduction instructions

  1. Go to the Global Styles section
  2. Open "Colors"
  3. Open "Palette"
  4. Edit any of the color palettes
@javierarce javierarce added Needs Design Feedback Needs general design feedback. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 10, 2022
@javierarce
Copy link
Contributor Author

javierarce commented Jan 10, 2022 •
edited
Loading

Here's a first proposal for the hover and selected states:

image

  • Hover: we highlight the text
  • Selected: we highlight the border of the item

@jorgefilipecosta jorgefilipecosta self-assigned this Jan 10, 2022
@jorgefilipecosta jorgefilipecosta mentioned this issue Jan 13, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 13, 2022
@naiba4 naiba4 mentioned this issue Nov 30, 2023
Open
@captainbarber99 captainbarber99 mentioned this issue Nov 30, 2023
Open
@soloinovator soloinovator mentioned this issue Dec 1, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 1, 2023
Open
@naiba4 naiba4 mentioned this issue Dec 1, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 1, 2023
Open
@naiba4 naiba4 mentioned this issue Feb 2, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Feb 3, 2024
Open
@yassine4999 yassine4999 mentioned this issue May 13, 2024
Open
@npneeraj npneeraj mentioned this issue May 13, 2024
Open
@jay-Anonymous jay-Anonymous mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add: Hover and Selected states to the palette editor. WordPress/gutenberg
2 participants
@javierarce @jorgefilipecosta