Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Font Family Support from various blocks for 5.9 #37826

Closed
luminuu opened this issue Jan 10, 2022 · 7 comments
Closed

Revert Font Family Support from various blocks for 5.9 #37826

luminuu opened this issue Jan 10, 2022 · 7 comments
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Technical Feedback Needs testing from a developer perspective. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@luminuu
Copy link
Member

luminuu commented Jan 10, 2022

While testing 5.9 RC1 I found that the font family selection for paragraphs was not yet available. @carolinan and @bph mentioned the issue #37586, however, it was discussed to revert that feature as the Webfont API is not ready yet, so it got removed with PR #37815.

While further testing I noticed that it is still in use by several blocks and to avoid unneccessary confusion in 5.9, I'd suggest to have it removed from those blocks as well:

  • List
  • Button
  • Verse
  • Navigation
  • Post Title
  • Archive Title
  • Website Title
  • Website Tagline
@annezazu annezazu added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. Needs Technical Feedback Needs testing from a developer perspective. labels Jan 10, 2022
@annezazu
Copy link
Contributor

cc @noisysocks for further review. Thank you for flagging this!

@noisysocks
Copy link
Member

@ntsekouras
Copy link
Contributor

I created a quick PR for this, if we decide we want to revert for other 5.9 blocks too. IMO this makes sense, but want to hear other's thoughts too 😄

@ntsekouras
Copy link
Contributor

Actually I saw that some blocks have this support from 5.8, so I'm not really sure.. 🤔

Example here.

@apeatling
Copy link
Contributor

@mtias comment specifically talked about making sure that font family was not a default control for these blocks when they are inserted. Blocks that already have font family could keep the support for it.

With the introduction of Tools Panel all of these blocks have font family hidden by default, so I think they are okay to leave as-is.

@ntsekouras
Copy link
Contributor

@mtias comment specifically talked about making sure that font family was not a default control for these blocks when they are inserted. Blocks that already have font family could keep the support for it.

Sounds good. There is no block with font family control set as default, so I guess we can close this issue, no?

@apeatling
Copy link
Contributor

Yes good to close. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Technical Feedback Needs testing from a developer perspective. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants