Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to deselect a block #3712

Closed
jasmussen opened this issue Nov 29, 2017 · 4 comments
Closed

Make it easier to deselect a block #3712

jasmussen opened this issue Nov 29, 2017 · 4 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

If you have a very brief post, clicking below the post no longer deselects the block:

can t select no metaboxes

This is likely a regression from the inline metaboxes. Previously the block container was at minimum 100% tall, meaning you could always click below the blocklist on short posts. Now it can't be 100% tall because there can be metaboxes:

can t select no metaboxes

The problem, likely, is that it's the block container that registers clicks as de-selects. Should we expand that so clicking anywhere outside the block itself deselects it?

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Nov 29, 2017
@aduth
Copy link
Member

aduth commented Nov 29, 2017

Should we expand that so clicking anywhere outside the block itself deselects it?

One complication here is that we need the block to remain selected in some cases when clicking outside:

  • Toolbar buttons
  • Sidebar inspector

@jasmussen
Copy link
Contributor Author

Another option is to distinguish between whether you have metaboxes or not, so we can at least have a 100% tall canvas if you don't have metaboxes. I also noticed that clicking left and right of the title block did not deselect blocks.

@aduth
Copy link
Member

aduth commented Jan 10, 2018

Technically a duplicate of #2322

@jasmussen
Copy link
Contributor Author

Closing on favor of that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants