Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Image block: enable option to upload an image within the placeholder #35689

Closed
annezazu opened this issue Oct 15, 2021 · 4 comments
Closed
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

Currently, if you don't have a featured image set for a post, you are shown an empty, non actionable placeholder for the featured image. This makes for either a confusing or lackluster experience where one has to leave the editing experience to find and edit that specific post to add a featured image.

For now after this testing, I believe it would have been great if there was some simpler way to upload featured image for posts in query loop.

Current view:

Screen Shot 2021-10-15 at 3 33 04 PM

This came up as part of the tenth call for testing for the FSE Outreach program.

What is your proposed solution?

While I know there are discussions around allowing for a fallback image #34865 and rethinking featured images in this context #27617, I believe that similar to the Site Logo block it might be smart to have a way to directly upload an image from the featured image block placeholder.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Post Featured Image Affects the Post Featured Image Block labels Oct 15, 2021
@jasmussen
Copy link
Contributor

CC: @jameskoster as we just conversed on a separate PR about these placeholders. I also recall you mentioning that items in these loops should perhaps be inert, which might suggest the placeholder disappearing entirely in the shown example?

@ntsekouras
Copy link
Contributor

Actually there is a way of uploading a featured image in the Placeholder. The above view is actually due to the not editable post blocks inside Query Loop. So maybe this issue is more related to the editable/non-editable post blocks?

@jameskoster
Copy link
Contributor

The Featured Image needs to entertain three scenarios:

  1. Data source present, no featured image set.
  2. Data source present, featured image set.
  3. No data source present.

In scenario one we need to render a placeholder which illustrates where the featured image would appear if set, and serve as a method to set it. In scenario two it must be possible to replace, or unset the current featured image, which effectively toggles it to scenario one.

For these two situations we can reuse the recently-implemented updates to the Site Logo block.

In the third scenario it should not be possible to set the featured image, but a placeholder should still appear.

@annezazu
Copy link
Contributor Author

In light of the efforts here #36136, wanted to follow up to see if this can officially be closed out! I'm asking because I noticed I can indeed upload an image within the Query Loop block and I'm not quite sure if that should be possible based on the convo above. Here's the current experience either way -- great work, folks, on improving the experience so dramatically:

featured.image.in.query.loop.placeholder.mov

cc @ntsekouras in particular around the editing abilities intended for 5.9 (this is using 5.9-beta3-52394).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants