Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to legacy widget blocks in the block widget editor don't get previewed #31190

Closed
draganescu opened this issue Apr 26, 2021 · 1 comment
Closed
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Description

As mentioned in #31094 legacy widgets do not show up in the Customizer embedded widget editor. But, if a legacy widget is added in the standalone editor, then it can be customized in the Customizer. I don't know if this bug is related to #31094 but, when values are updated in the legacy widget's form the changes are not previewed in the preview panel.

Step-by-step reproduction instructions

  1. Have Gutenberg trunk and a theme with sidebars
  2. Install Site Origin widget bundle
  3. Go to Appearance > Widgets
  4. Add the accordion widget from Site Origin to any widget area (sidebar)
  5. Save
  6. Go to Appearance > Customize > Widgets > [your widget area]
  7. Notice the accordion widget is perfectly editable
  8. Change the title of the widget or some of the panels
  9. Notice the preview of the Customizer does not show the changes
  10. Notice the legacy widget preview does show the changes

Expected behaviour

The legacy widget preview and the customizer preview should be in sync and show the same updated view.

Actual behaviour

The customizer preview does not get any updates when customizing a legacy widget, but the legacy widget block's preview is up to date.

Screenshots or screen recording (optional)

no-update-legacy-customizer.mp4
@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. labels Apr 26, 2021
@noisysocks
Copy link
Member

This appears to be working fine for me, although the widget is a little difficult to use without #31194.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants