Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpautop is applied to server-side rendered block output #2736

Closed
lamosty opened this issue Sep 15, 2017 · 2 comments
Closed

wpautop is applied to server-side rendered block output #2736

lamosty opened this issue Sep 15, 2017 · 2 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended

Comments

@lamosty
Copy link
Member

lamosty commented Sep 15, 2017

While working on creating a block for the Jetpack subscription functionality, I stumbled upon an issue: if the output from the render_callback function contains inline JS (like this), wpautop will add paragraphs to the JS code so it won't work:

screen shot 2017-09-15 at 14 56 24

If I return early from wpautop, no <p>s are added.

#gutenbug
@lamosty lamosty added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended labels Sep 15, 2017
@georgestephanis
Copy link
Contributor

Related: #1244

@aduth aduth mentioned this issue Sep 25, 2017
Merged
@aduth
Copy link
Member

aduth commented Sep 25, 2017

Additional context / proposed solutions at #2708 (comment)

@aduth aduth mentioned this issue Sep 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgestephanis @aduth @lamosty