Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive minimum 200px height in Shortcode block #26410

Closed
oldrup opened this issue Oct 23, 2020 · 2 comments · Fixed by #26456
Closed

Excessive minimum 200px height in Shortcode block #26410

oldrup opened this issue Oct 23, 2020 · 2 comments · Fixed by #26456
Assignees
@jasmussen
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Shortcodes Related to shortcode functionality [Status] In Progress Tracking issues with work in progress

Comments

@oldrup
Copy link

oldrup commented Oct 23, 2020

Hey

I actually thought this was an issue with my theme, but it appears to be a - maybe deliberate - design choice. There is a 200px min height on the shortcode block. Please see attached screenshot. That does appear odd, especially in context with other blocks that have a height that fits their content. Removing the min-height style, looks a lot nice in my opinion.

excessive height on some blocks

Kind regards
Bjarne
@ntsekouras ntsekouras added [Feature] Shortcodes Related to shortcode functionality CSS Styling Related to editor and front end styles, CSS-specific issues. labels Oct 26, 2020
@ntsekouras
Copy link
Contributor

Hey @oldrup - thanks for the suggestion! Maybe @jasmussen is better to share his thoughts here.

@jasmussen jasmussen mentioned this issue Oct 26, 2020
Merged
@jasmussen
Copy link
Contributor

Nice one! I created #26456 to fix it.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 26, 2020
@yaseenaljamal yaseenaljamal mentioned this issue Sep 13, 2023
Open
@naiba4 naiba4 mentioned this issue Mar 12, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Mar 13, 2024
Open
@naiba4 naiba4 mentioned this issue Apr 22, 2024
Open
@naiba4 naiba4 mentioned this issue May 13, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Shortcodes Related to shortcode functionality [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polish shortcode block. WordPress/gutenberg
3 participants
@jasmussen @ntsekouras @oldrup