Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid block warning dropdown menu cannot be navigated using arrow keys. #24303

Closed
talldan opened this issue Jul 31, 2020 · 0 comments · Fixed by #24333
Closed

Invalid block warning dropdown menu cannot be navigated using arrow keys. #24303

talldan opened this issue Jul 31, 2020 · 0 comments · Fixed by #24333
Assignees
@ntsekouras
Labels
[Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress

Comments

@talldan
Copy link
Contributor

talldan commented Jul 31, 2020

Describe the bug
When a user has an invalid block, the extra options in the dropdown cannot be navigated using a keyboard. The dropdown closes and focus is moved in an unexpected way.

Possibly another issue with WritingFlow interrupting keyboard navigation.

To reproduce
Steps to reproduce the behavior:

  1. Add a block and make it invalid by switching to the code editor and editing the markup (e.g. changing the tags)
  2. Try opening the additional options using the keyboard and navigating between the options using arrow keys.
  3. Observe the dropdown menu closes unexpectedly and focus jumps to elsewhere in the editor

Expected behavior
The user can navigate between the options and the menu stays open.

Screenshots
Screenshot 2020-07-31 at 1 56 36 pm
@talldan talldan added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [a11y] Keyboard & Focus labels Jul 31, 2020
@ntsekouras ntsekouras self-assigned this Aug 3, 2020
@ntsekouras ntsekouras mentioned this issue Aug 3, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add arrow navigation to Warning dropdown menu WordPress/gutenberg
2 participants
@talldan @ntsekouras