Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Block: Smaller viewport widths losing container padding #19689

Closed
apeatling opened this issue Jan 15, 2020 · 2 comments
Closed

Nav Block: Smaller viewport widths losing container padding #19689

apeatling opened this issue Jan 15, 2020 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@apeatling
Copy link
Contributor

apeatling commented Jan 15, 2020 •
edited by retrofox
Loading

⚠️ IMPORTANT
Let's wait until #19681 ships before to work on this, since it will introduce many changes in the styles organization.

Describe the bug
On smaller viewport widths the navigation items switch to vertical, but there is no container padding so the links hit up against the edge.

Screen Shot 2020-01-15 at 3 20 03 PM

To reproduce
Steps to reproduce the behavior:

  1. Add a navigation block with some items
  2. View the nav block in the front end at a smaller viewport width

Expected behavior
Some amount of padding suitable for smaller screens.
@apeatling apeatling added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 15, 2020
@apeatling
Copy link
Contributor Author

Related #19688

@obenland obenland added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 20, 2020
@retrofox
Copy link
Contributor

retrofox commented Feb 4, 2020

Fixed in #19681

@retrofox retrofox closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@retrofox @obenland @apeatling