Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Site: Isolate template parts for editing #19253

Closed
mtias opened this issue Dec 19, 2019 · 22 comments
Closed

Edit Site: Isolate template parts for editing #19253

mtias opened this issue Dec 19, 2019 · 22 comments
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@mtias
Copy link
Member

mtias commented Dec 19, 2019

In the new edit-site context, it'd be good to explore a view mode that allows focusing only on a template part while editing.

Example (Header):
image

I imagine it could be added here as a section (Template Parts):

image

@jasmussen
Copy link
Contributor

jasmussen commented Dec 20, 2019

In #19082 (comment) I shared a mockup that embraces the same "View" dropdown, for starters just showing the responsive breakpoints. The dropdown interface scales well in an area that is already crowded, especially with the "Top Toolbar" option, and I could well see it scale to fit templates, perhaps in a pattern similar to what's shown in #19252.

@epiqueras
Copy link
Contributor

That's similar to how I implemented it for now: #19252 (comment).

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Jan 7, 2020
@MichaelArestad
Copy link
Contributor

Can you provide an example situation where editing a template part in isolation would be necessary/useful?

@epiqueras
Copy link
Contributor

Whenever you want to focus on a very reused part, like a header.

@mtias
Copy link
Member Author

mtias commented Jan 9, 2020

Also for a complex site (a large magazine) it might be reassuring to focus on a specific area (featured content, widget area, etc) knowing you won't affect the rest of the site by mistake.

@jasmussen
Copy link
Contributor

A tangentially related use case is to have something more akin to a "template editor", where you might have a list of templates in a theme-package as a list where you can click to edit each. Having this overview of all the ingredients that make up your site is likely going to be crucial for editing templates that are otherwise not easy to navigate to organically, such as 404.

@mtias
Copy link
Member Author

mtias commented Jan 10, 2020

That is meant to be covered by #19252 or were you thinking about something else?

@jasmussen
Copy link
Contributor

Nope, I had forgotten about that one. That covers the 404 case. As you were!

@mtias
Copy link
Member Author

mtias commented Mar 8, 2020

The bulk of this already works, but should be updated to use the same visual treatment as the device preview:

Template Part focused:
image

Device preview:
image

@mapk
Copy link
Contributor

mapk commented Mar 14, 2020

Along the path of @MichaelArestad's and @shaunandrews' recent explorations, I fixed up a prototype of how this could work when isolating template parts.

Prototype

isolate-part

Figma
https://www.figma.com/file/TR15iRvk7toGHnKb68QN1K/Full-Site-Editing?node-id=1405%3A2

@MichaelArestad
Copy link
Contributor

@mapk I think this is a solid direction. My only feedback is super minor so I'll save that for the PR. Let's move forward with this concept for now.

@MichaelArestad MichaelArestad added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Mar 19, 2020
@vindl vindl self-assigned this Apr 1, 2020
@MichaelArestad
Copy link
Contributor

Very minor update:

image

Figma link to the frame

@MichaelArestad
Copy link
Contributor

It seems like this already works pretty close to the designs. Closing for now.

image

@mtias mtias reopened this Oct 23, 2020
@mtias
Copy link
Member Author

mtias commented Oct 23, 2020

Reopening since it's not possible to focus just on one element from the toolbar anymore:

image

cc @shaunandrews @jameskoster

@jameskoster
Copy link
Contributor

I feel like I'm missing something super obvious, but if I’m editing a template and can see the "Header" Template Part, why would I need to visually isolate it? Why not just click in and edit as normal? The top bar indicates that I'm editing a Template Part, what more information is required?

I understand the need perhaps for a 'mosaic' style view of all Template Parts, with management functions (trash). And from there I might enter an an isolated view to edit a specific Template Part. But I’m not sure we need a shortcut to that view from regular template editing.

@mtias
Copy link
Member Author

mtias commented Oct 23, 2020

Being able to isolate template parts is a crucial part of the flow to me. It can be a great way to collaborate without running into each other. It can give a good sense of focus. It can help reach specific parts that might be hard to get to when in their final place (edges). It can allow editing templates that might not be immediately visible (a fixed header that slides in, for example) in a much more organized context. Etc.

@jameskoster
Copy link
Contributor

I suppose we'll need the isolated view regardless, so it can't hurt to have a shortcut to that from template editing 👍

@noahtallen
Copy link
Member

noahtallen commented Oct 26, 2020

@matias this is actually still possible by selecting a template part from the nav sidebar.

I’ve heard different approaches re the template part text in the header:

  1. Clicking it does nothing because it could be confusing for accessibility
  2. Clicking it selects the template part
  3. Clicking it “zooms in” to the template part

@mtias
Copy link
Member Author

mtias commented Oct 28, 2020

@noahtallen yes, sorry, I mean accessing from within the editor interface itself.

@jameskoster
Copy link
Contributor

jameskoster commented Oct 30, 2020

Here's an idea for Template part isolation:

Screenshot 2020-10-30 at 15 35 28

The back arrow / link would only appear on occasions where a user enters Template Part Isolation directly from another document.

Upon isolation the Template Part will appear slightly offset on the Canvas, with a border to indicate its boundaries.

@vindl vindl removed their assignment Nov 3, 2020
@carolinan
Copy link
Contributor

I believe that this has been solved and that the issue can be closed?
Or do we still want to add an edit link to the block inspector as in the screenshot?

@jameskoster
Copy link
Contributor

We have a basic implementation, so can probably close this issue and continue refining in #29148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

10 participants