Multi-Select: Selection not always clearing

[jasmussen]

When you click outside blocks to deselect, the new native multiselect doesn't always clear. That is — is-multi-selected is always properly cleared, but the selection marker isn't.

• It appears most of the time that if you start and end the selection in a paragraph, selection does clear when clicking outside.
• The issue seems to be easiest to reproduce when starting selection in text, then stopping in a non-paragraph block such as Image.

However the above isn't completely consistent. GIF:

@ellatrix do you have any idea what might cause this?

[ellatrix]

@jasmussen Which browser is this? I have a tried in both Chrome and Firefox and cannot reproduce.

[jasmussen]

Chrome, Mac. I'll try and repro in Firefox.

[jasmussen]

I'm seeing some additional issues, and I'm starting to suspect it may be editor style related. The following issues are both in twentytwenty, probably in others but haven't tested that.

Issue 1: can't click left or right of the block to clear multi selection:

I can click on a single block to select that, which clears the multi select. But there doesn't appear to be any other way to do so.

I know we've removed a lot of divs from the editing canvas lately, is it possible we removed one of the divs holding the click trigger to clear the block selection?

Issue 2: if I drag outside the bottom of the canvas, into the invisible appender, the multi selection is cleared instantly:

[ellatrix]

@jasmussen No, we didn't remove hat div. :) It's likely to be #19762, there's a new focusable container which now seems to be capturing the focus instead of the element clearing the selection. This is not part of the 7.3 release. I'll look into a fix, and I'll also look into the other issues.

[ellatrix]

It doesn't look like there was an e2e test for this behaviour, so I'll add that too.

[jasmussen]

This issue appears to have been fixed!