Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird text focus issue after clicking a reusable block #18977

Closed
ZebulanStanphill opened this issue Dec 6, 2019 · 3 comments
Closed

Weird text focus issue after clicking a reusable block #18977

ZebulanStanphill opened this issue Dec 6, 2019 · 3 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Dec 6, 2019

The issue

After clicking a reusable block and then clicking a text block and then clicking another text block, you will not be able to set your text cursor in the text block. This issue is not present in Gutenberg 7.0.0.

How to reproduce

  1. Create and save a post containing a reusable block (containing whatever, it doesn't matter), followed by a Paragraph (A) and then another Paragraph (B).
  2. Refresh the page.
  3. Click the reusable block.
  4. Click Paragraph A.
  5. Click Paragraph B.
  6. Try to edit the text in Paragraph B. Notice that your text cursor can't be put into Paragraph B.

Environment

  • WordPress 5.4-alpha-46814
  • Gutenberg master as of 72d9bd0
  • Using Dissenter browser 0.70 (based on Chromium 78)
@ZebulanStanphill ZebulanStanphill added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Regression Related to a regression in the latest release labels Dec 6, 2019
@bobbingwide
Copy link
Contributor

I've been having this problem as well. The problem doesn't appear to be limited to reusable blocks.

Workaround

Switch to Code editor and back again.

Is this console message related to this issue?

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in t (created by Context.Consumer)
    in oe (created by Hc)
    in div (created by Rs)
    in Rs (created by Ls)
    in Ls (created by Ks)
    in Ks (created by Hc)
    in div (created by Hc)
    in Hc (created by Vc)
    in te (created by Context.Consumer)
    in ne (created by BlockFormatControlsFill)
    in BlockFormatControlsFill (created by Context.Consumer)
    in IfBlockEditSelected(BlockFormatControlsFill) (created by Vc)
    in Vc (created by t)

@ZebulanStanphill
Copy link
Member Author

@bobbingwide I'm not seeing any React errors in the JavaScript console, though maybe it's because I'm testing on the plugin (version 7.2.0) rather than master and I'm not using React DevTools or something like that.

@talldan
Copy link
Contributor

talldan commented Jan 24, 2020

This seems to have been resolved by #19839. 🎉

@talldan talldan closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants