Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sub items to menu is confusing visually with all the + icons #18333

Closed
karmatosed opened this issue Nov 6, 2019 · 8 comments
Closed
Assignees
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

If you add a few sub-items you get this visual:

nav-subconfuse

I would suggest that seeing just one is better and this isn't a great experience for people, beyond the background not letting me see the '+' any way that well.

@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels Nov 6, 2019
@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Nov 6, 2019
@mapk
Copy link
Contributor

mapk commented Nov 7, 2019

Ooooh. Those trailing + icons are all over the place! Definitely needs help.

Screen Shot 2019-11-06 at 4 09 55 PM

Can we drop those + icons completely since we have a block toolbar icon that adds more submenu items?

Screen Shot 2019-11-06 at 4 11 32 PM

@mapk
Copy link
Contributor

mapk commented Nov 7, 2019

We could probably drop them from the sidebar too!

Screen Shot 2019-11-06 at 4 12 36 PM

@mtias
Copy link
Member

mtias commented Nov 7, 2019

The plus is a trailing inserter when a sub-menu already exists. It should show only for the currently selected level.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 7, 2019
@obenland
Copy link
Member

obenland commented Jan 9, 2020

Work on #18310 should help alleviate some of this pain

@draganescu
Copy link
Contributor

It feels as if this is a bug. I think I can remember that at some point all sub items behaved like the main items, and you could (like @mtias describes) only see the appender for the currently selected level.

@draganescu
Copy link
Contributor

Yes, I found in git history that there was an issue with the registration of allowed blocks which prompted @talldan to hide menu items with css instead, but that leaves "on" all those appenders.

I added this #19598 small PR to hide appenders for other navigation levels. Not sure if this is the best approach but if it is, it will help when we implement those flyout ideas in #18310.

@draganescu draganescu self-assigned this Jan 13, 2020
@draganescu draganescu added the [Status] In Progress Tracking issues with work in progress label Jan 17, 2020
@obenland
Copy link
Member

@draganescu Was this fixed by #19598?

@talldan
Copy link
Contributor

talldan commented Jan 23, 2020

Yep, I think this is fixed by #19598.

@talldan talldan closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants