Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Ensure that ExternalLink component doesn't show up visually hidden elements when rendered outside of WordPress #18127

Closed
gziolo opened this issue Oct 28, 2019 · 1 comment · Fixed by #18142
Closed

Components: Ensure that ExternalLink component doesn't show up visually hidden elements when rendered outside of WordPress #18127

gziolo opened this issue Oct 28, 2019 · 1 comment · Fixed by #18142
Assignees
@mkaz
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress Storybook Storybook and its stories for components [Type] Code Quality Issues or PRs that relate to code quality

Comments

@gziolo
Copy link
Member

gziolo commented Oct 28, 2019

Describe the bug
Discovered when testing the Storybook integration of the ExternalLink component. See the related comment #18084 (comment):

CSS styles for screen-reader-text don't load:

Screen Shot 2019-10-28 at 07 59 31

To reproduce
Steps to reproduce the behavior:

  1. Run Storybook: npm run design-system:dev.
  2. Go to the ExternalLink section.

Expected behavior
(open in a new tab) text is only visible for screen readers. Instead of using the class screen-reader-text, the text should be put inside the VisuallyHidden component introduced by @mkaz in #18022. You can also check a similar refactoring in #18013.
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Oct 28, 2019
@gziolo gziolo mentioned this issue Oct 28, 2019
Merged
@youknowriad
Copy link
Contributor

Wes should do a global PR that replaces all usages of screen-reader-text className with VisuallyHidden component;

@mkaz mkaz mentioned this issue Oct 28, 2019
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 28, 2019
This was referenced Oct 29, 2019
Merged
Closed
@gziolo gziolo added the Storybook Storybook and its stories for components label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaz mkaz

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress Storybook Storybook and its stories for components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ExternalLink Component to fix visually hidden text WordPress/gutenberg
3 participants
@mkaz @youknowriad @gziolo