Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image, Gallery: Improve "Edit Image" flow if we can #1725

Closed
jasmussen opened this issue Jul 5, 2017 · 12 comments
Closed

Image, Gallery: Improve "Edit Image" flow if we can #1725

jasmussen opened this issue Jul 5, 2017 · 12 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@jasmussen
Copy link
Contributor

WordPress comes with a nice built in image editing tool. Right now you can access it by first clicking the edit button on an image:

screen shot 2017-07-05 at 13 59 27

then click the little "Edit Image" link:

screen shot 2017-07-05 at 13 58 48

Clicking this, though, opens in a new window, with a URL of something like /wp-admin/post.php?post=40&action=edit&image-editor.

Is there a simple/quick way we can improve this flow as an interim solution to something even better?

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Jul 5, 2017
@jasmussen jasmussen added this to the Beta 0.8.0 milestone Jul 5, 2017
@jasmussen
Copy link
Contributor Author

If you edit an inserted image in the old editor, you get this interface:

screen shot 2017-07-05 at 14 06 17

screen shot 2017-07-05 at 14 06 29

It would be nice if we could utilize this style here.

@karmatosed
Copy link
Member

As reported also in #2075, something needs to be done to fix the broken flow we have right now. For now, marking this as a higher priority and for 0.8.

@karmatosed karmatosed added the [Priority] High Used to indicate top priority items that need quick attention label Aug 3, 2017
@nic-bertino
Copy link

Something to react to on this, but it may be worth prototyping and testing.

image inserter

@mtias mtias modified the milestones: Beta 0.9.0, Beta 0.8.0 Aug 10, 2017
@mtias mtias modified the milestones: 0.11.0, Beta 0.9.0 Aug 18, 2017
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Aug 30, 2017
@karmatosed karmatosed modified the milestones: Beta 1.2, Beta 1.1 Aug 31, 2017
@mtias mtias removed the [Priority] High Used to indicate top priority items that need quick attention label Sep 6, 2017
@mtias mtias modified the milestones: Beta, Needs to happen, Beta 1.2 Sep 6, 2017
@karmatosed karmatosed self-assigned this Sep 24, 2017
@karmatosed
Copy link
Member

karmatosed commented Sep 29, 2017

I did a couple of explorations to show how we could go here.

First up, the 'easy win'. This simply makes sure if you were in Gutenberg that the link after edited goes back to Gutenberg:

01

The next option takes everything that currently happens in editing 'into Gutenberg. This does not change or adjust anything. For what it's worth that editing screen I feel needs some work (outside Gutenberg), however we need to be cautious dropping anything and going down that rabbit hole yet. For now, putting everything in seems a fair middle ground if we go this route:

02

Note: only did first screen as we need to decide which route we go.

@jasmussen
Copy link
Contributor Author

I think your suggestions sound pragmatic, Tammie. Agree that media as a whole needs an iteration of its own, perhaps even a focus, so we should probably focus on quick wins there.

@karmatosed
Copy link
Member

Agree that media as a whole needs an iteration of its own, perhaps even a focus, so we should probably focus on quick wins there.

@jasmussen absolutely. This is slightly my concern by putting it into the small screen, although we totally should explore if that's possible.

@mtias what do you think? My thinking is we could get the low hanging option in, then maybe also evaluate the 'everything in Gutenberg' option for editing.

@karmatosed karmatosed removed their assignment Oct 2, 2017
@jasmussen
Copy link
Contributor Author

Will this improve automatically now that Gutenberg when the plugin is activated sets itself as the default editor? @karmatosed

@karmatosed
Copy link
Member

Unfortunately the pitfall of a new tab opening and then having no way back - unless I remember or notice it's a new tab - on editing, is still there @jasmussen. We should cover that trap for users.

@karmatosed
Copy link
Member

Confirming that right now we have a new tab. We could add a link to say 'back to editor' that would solve some issues. However, I think taking a little bit to work on this would be sound.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jan 3, 2018
@karmatosed karmatosed modified the milestones: Needs to happen, 2.1 Jan 3, 2018
@karmatosed karmatosed added the [Feature] Media Anything that impacts the experience of managing media label Jan 3, 2018
@karmatosed karmatosed modified the milestones: 2.1, 2.2 Jan 25, 2018
@aduth aduth modified the milestones: 2.2, 2.3 Feb 14, 2018
@mellis32
Copy link

mellis32 commented Feb 20, 2018

Why was 'Custom' not an option in the in Gutenberg image scaling dropdown?

As far as I can tell the only way to scale the image precisely is to edit the Media file directly?

@aduth aduth modified the milestones: 2.3, 2.4 Mar 1, 2018
@karmatosed karmatosed modified the milestones: 2.4, 2.5, Merge Proposal Mar 7, 2018
@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Media Apr 12, 2018
@mtias mtias removed this from the Merge: Media milestone Oct 3, 2018
@aaronjorbin
Copy link
Member

I don't view this experience being any worse than what is currently in core and has been the norm for core. So pushing it tofuture

@mtias mtias added this to the Future: 5.1 Onwards milestone Oct 12, 2018
@jasmussen
Copy link
Contributor Author

I'm actually going to close this one, as the user interface has changed so much that what's discussed is likely not super actionable anymore. Additionally, the flow has improved, with big buttons and patterns for changing an existing gallery.

With separate efforts to explore galleries leveraging child blocks, and separate improvements to the media library, all the more reason to revisit if and when it becomes necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

8 participants