Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text: Non-selected inline boundaries wrongly highlighted on blur #15463

Closed
aduth opened this issue May 6, 2019 · 0 comments · Fixed by #15466
Closed

Rich Text: Non-selected inline boundaries wrongly highlighted on blur #15463

aduth opened this issue May 6, 2019 · 0 comments · Fixed by #15466
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Milestone

Comments

@aduth
Copy link
Member

aduth commented May 6, 2019

Related: #14120 (cc @ellatrix )

Describe the bug

Similar to what was demonstrated in #14120, it can occur that all inline boundaries of a kind appear as highlighted when deselecting a paragraph while the caret is within an inline boundary.

To reproduce

Steps to reproduce the behavior:

  1. Navigate to Posts > Add New
  2. Add a paragraph with bolded text
  3. Add another paragraph with bolded text
  4. Click within one or the other of the bolded fragments from Step 2 or Step 3
  5. Click in the gutters to the left or right of the block list to deselect the current paragraph
  6. Note that both bolded texts appear as highlighted

Expected behavior

Neither bolded text should appear as highlighted.

Screenshots

highlight

Desktop (please complete the following information):

  • OS: macOS Mojave 10.14.4 (18E226)
  • Browser: Version 74.0.3729.131 (Official Build) (64-bit)
  • Gutenberg version: wordpress-develop@96649a5 (effectively WordPress 5.2-RC.2)

Additional context

It seems to be important that the highlight had at one point previously been highlighted, in order for it to appear as highlighted when deselecting the block.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels May 6, 2019
@ellatrix ellatrix added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label May 14, 2019
@ellatrix ellatrix added this to the 5.7 (Gutenberg) milestone May 14, 2019
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants