Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-align border for right-aligned quotes #11609

Closed
sarahmonster opened this issue Nov 8, 2018 · 4 comments
Closed

Right-align border for right-aligned quotes #11609

sarahmonster opened this issue Nov 8, 2018 · 4 comments
Labels
[Block] Quote Affects the Quote Block [Type] Enhancement A suggestion for improvement.

Comments

@sarahmonster
Copy link
Member

To improve the consistency of alignments and to avoid creating potentially-awkward rivers inside the quote block, I'd recommend adjusting the positioning of the hard left border on the quote block when the alignment is changed, so it would be to the right on a right-aligned quote, and either removed or maybe at the top of a centre-aligned block.

Left-aligned

screenshot 2018-11-08 01 07 40

Suggestion is to remain as-is, since the alignment here is consistent with the text.

Centre-aligned

screenshot 2018-11-08 01 07 29

Suggestion:
screenshot 2018-11-08 01 08 57

Right-aligned
screenshot 2018-11-08 01 07 50

Suggestion:
screenshot 2018-11-08 01 08 17

@sarahmonster sarahmonster added [Type] Enhancement A suggestion for improvement. [Block] Quote Affects the Quote Block labels Nov 8, 2018
@sarahmonster sarahmonster mentioned this issue Nov 8, 2018
9 tasks
@colorful-tones
Copy link
Member

I'm going to take a pass at updating the CSS around this now. (via @10up).

@colorful-tones
Copy link
Member

Currently the Quote block is not using className on <blockquote>, which is problematic for adding the proposed variations mentioned above.

Currently, when alignment is switched it is just setting a style property on the element: <blockquote style="text-align: left;"></blockquote>

Whereas, we would want to leverage a class property instead: <blockquote class="blockquote-left">.

I'll continue to try and work up a PR, but I'm newer to React/Gutenberg. So somebody might beat me to it. Feel free!

@colorful-tones
Copy link
Member

@sarahmonster I would love your feedback on the styling enhancements in submitted PR. Note: I went in a little different direction for center aligned quotes. Thanks!

@colorful-tones
Copy link
Member

Tagging #10970 as they are related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants