Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image & Audio: Auto switch to Embed for embeddable URLs #11427

Closed
Soean opened this issue Nov 2, 2018 · 1 comment
Closed

Image & Audio: Auto switch to Embed for embeddable URLs #11427

Soean opened this issue Nov 2, 2018 · 1 comment
Labels
[Block] Audio Affects the Audio Block [Block] Embed Affects the Embed Block [Block] Image Affects the Image Block Needs Design Feedback Needs general design feedback.

Comments

@Soean
Copy link
Member

Soean commented Nov 2, 2018

Description
The PR #11410 switches the Video block to Embed, if the user tries to add a embeddable URL like YouTube or Vimeo.
We should also add this feature to the Image block if the user tries to add a URL like Instagram and to the Audio block if the user tries to add a URL like SoundCloud.
@Soean Soean added [Block] Embed Affects the Embed Block [Block] Image Affects the Image Block [Block] Audio Affects the Audio Block and removed [Block] Audio Affects the Audio Block [Block] Image Affects the Image Block labels Nov 2, 2018
@designsimply designsimply added the Needs Design Feedback Needs general design feedback. label Nov 2, 2018
@alexislloyd
Copy link
Contributor

This seems like a good user flow to me — aligns to user expectations and creates a consistent experience across blocks.

@Soean Soean mentioned this issue Nov 4, 2018
Merged
@yassine4999 yassine4999 mentioned this issue Jun 20, 2023
Open
This was referenced Jun 20, 2023
Open
Open
This was referenced Jul 6, 2023
Open
Open
Open
@yassine4999 yassine4999 mentioned this issue Jul 8, 2023
Open
This was referenced Nov 27, 2023
Open
Open
This was referenced Nov 28, 2023
Open
Open
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Dec 2, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Dec 13, 2023
Open
@yassine4999 yassine4999 mentioned this issue Dec 13, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Dec 15, 2023
Open
@yassine4999 yassine4999 mentioned this issue Dec 18, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Dec 26, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Mar 22, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Mar 25, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Apr 7, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Apr 30, 2024
Open
@yassine4999 yassine4999 mentioned this issue May 13, 2024
Open
This was referenced May 14, 2024
Open
Open
@yassine4999 yassine4999 mentioned this issue May 14, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue May 15, 2024
Open
@yassine4999 yassine4999 mentioned this issue May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Audio Affects the Audio Block [Block] Embed Affects the Embed Block [Block] Image Affects the Image Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Soean @designsimply @alexislloyd