Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of the word in italic covers partly letter next to it when the caret is active inside the inline boundary #11423

Closed
paaljoachim opened this issue Nov 2, 2018 · 5 comments · Fixed by #13697
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Milestone

Comments

@paaljoachim
Copy link
Contributor

Describe the bug
Doing some of the word in italic covers over the letters beside it.

To Reproduce
Steps to reproduce the behavior:

  1. Do part of the word italic and the letter beside it will perhaps also be partly covered.

Expected behavior
Not to cover the letter beside that is not italic

Screenshots
screen shot 2018-11-02 at 17 25 02

Desktop (please complete the following information):

  • OS: Mac os 10.13.6
  • Browser Chrome with Desktop Server
  • Gutenberg version 4.1.1
@paaljoachim paaljoachim changed the title Part of the word in italic covers other letters Part of the word in italic covers partly letter next to it. Nov 2, 2018
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 2, 2018
@jesscga
Copy link

jesscga commented Nov 2, 2018

I tested this as well - when I added the italic text, the initial letter was covered. As soon as I clicked off the word, the italic text and non-italic text were unhighlighted and visible.

Screencast here: http://cld.wthms.co/b8zQku

OS: macOS 10.13.6
Browser: Chrome Version 69.0.3497.100
Gutenberg version 4.1.1

@designsimply designsimply changed the title Part of the word in italic covers partly letter next to it. Part of the word in italic covers partly letter next to it when the caret is active inside the inline boundary Nov 2, 2018
@designsimply designsimply added Needs Design Feedback Needs general design feedback. and removed Needs Testing Needs further testing to be confirmed. labels Nov 2, 2018
@designsimply
Copy link
Member

This feels like a bit of an edge case to me which may be acceptable because I noticed in @jesscga's screencast that the problem only shows up when the inline boundary is active with the caret placed inside the italic text. However, it would be good to get a second opinion so I've added the Needs Design Feedback label to see if we can get a check on that.

@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Nov 4, 2018
@karmatosed
Copy link
Member

I feel for now in confines of what we have this could be acceptable. However, let's put to 5.0.1 and see if it can be iterated.

@karmatosed karmatosed added this to the WordPress 5.0.1 milestone Nov 22, 2018
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Nov 22, 2018
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Jan 29, 2019
@azaozz
Copy link
Contributor

azaozz commented Jan 31, 2019

This is "purely" a styling issue. Removing the padding and (negative) margin from selected <em> tags (and any other selected tags that have inline boundaries) seems to fix it.

Before (the last letter before the selection is not visible):

selected-em-tag-before

After (all letters are visible):

selected-em-tag

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Feb 8, 2019

Thanks for taking care of this issue @iseulde Ella!

I look forward to trying this out in the next GB version as I have seen in a few instances that the last letter gets partly covered up. Example paragraph text, caption etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants