Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTokenField.moveInput{stuff} methods should update setState #1122

Closed
BE-Webdesign opened this issue Jun 11, 2017 · 0 comments
Closed

FormTokenField.moveInput{stuff} methods should update setState #1122

BE-Webdesign opened this issue Jun 11, 2017 · 0 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@BE-Webdesign
Copy link
Contributor

Current:

moveInputToIndex( index ) {
	this.setState( {
		inputOffsetFromEnd: this.props.value.length - Math.max( index, -1 ) - 1,
	} );
}

moveInputBeforePreviousToken() {
	this.setState( {
		inputOffsetFromEnd: Math.min( this.state.inputOffsetFromEnd + 1, this.props.value.length ),
	} );
}

moveInputAfterNextToken() {
	this.setState( {
		inputOffsetFromEnd: Math.max( this.state.inputOffsetFromEnd - 1, 0 ),
	} );
}

Should be:

moveInputToIndex( index ) {
	this.setState( ( previousState, props ) => ( {
		inputOffsetFromEnd: props.value.length - Math.max( index, -1 ) - 1,
	} ) );
}

moveInputBeforePreviousToken() {
	this.setState( ( previousState, props ) => ( {
		inputOffsetFromEnd: Math.min( previousState.inputOffsetFromEnd + 1, props.value.length ),
	} );
}

moveInputAfterNextToken() {
	this.setState( ( previousState ) => ( {
		inputOffsetFromEnd: Math.max( previousState.inputOffsetFromEnd - 1, 0 ),
	} );
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants