JS Warnings when changing the publish date

[afercia]

Describe the bug
Not sure this is already tracked. If it's a known issue, of course do feel free to close.

On current master:

• create a post
• click the Publish date button and observe your browser's dev tools console
• as soon as the date picker opens, I'm getting this JS Warning:

Warning: Failed prop type: DayPickerSingleDateController: unknown props found: block

[desrosj]

@afercia I am unable to reproduce this. Can you give me more details about which WP version, Gutenberg version, and date format the site has selected?

[afercia]

@desrosj this was tested on WP trunk and Gutenberg master 5 days ago, default date format F j, Y g:i a. Cannot reproduce now, however I'm not sure DayPickerSingleDateController has a block prop, see https://github.com/airbnb/react-dates/blob/60025377603ac1bb042b525d499ea0d5dc814e89/src/components/DayPickerSingleDateController.jsx

I see this props is passed to the component though:

gutenberg/packages/components/src/date-time/date.js

Lines 44 to 45 in a696e50

	<DayPickerSingleDateController
	block

[Ferdev]

we're also seeing this issue in https://github.com/woocommerce/woocommerce-bookings
We're just using the DatePicker class from @wordpress/components, and we get the warning whenever we run the plugin under WordPress 5.0.3 (it does work in 5.0.2 and previous versions).

As @afercia pointed out, I don't think DayPickerSingleDateController has a block property, but it does have a blocked property I think... Maybe it was just typo.

We'd appreciate any info you could give us, thanks!

Steps to reproduce the issue:

1. WordPress 5.0.3 fresh install
2. Install & activate the WooCommerce plugin.
3. Install & activate the WooCommerce Bookings plugin.
4. Execute npm run start on the WooCommerce Bookings plugin folder
5. In the Admin, go to Bookings->Calendar an click on the month name on the calendar's title.
6. The error should pop up in the browser's dev console.

[afercia]

Yep, I still see it on current master 16b94bb when opening the Publish date picker.

[bor0]

I can't reproduce this on WordPress 5.2.2.

[gziolo]

I'm seeing this React deprecations listed:

[glendaviesnz]

I am not seeing any console errors with the date picker in WordPress 5.3 with Gutenberg 7.0.0

[afercia]

Looks like the block property was removed in #12933 thus fixing this issue.