Update to Babel 7.4 and core-js 3 (#15139)

* Specify core-js version when using useBuiltIns * Update to Babel 7.4 and core-js 3 * setupFiles: fix path to async-iterator * Also update Babel packages in babel-preset-default * Update snapshot for babel-preset-default test * Manually include web.dom-collections.iterator in jest config * Regenerate package-lock.json file after latest changes applied * Upgrade ESLint related npm packages * Another cleanup in the package-lock.json file * Remove ESLint rules which throw error to fix linting * Add core-js/modules/web.dom.iterable to make e2e tests work * Update Babel packages to the latest version * Update ignore files in e2e tests config * Add changelog entries related to Babel and ESLint version bumps
WordPress · Apr 30, 2019 · 5e4d627 · 5e4d627
1 parent 1d959ba
commit 5e4d627
Show file tree

Hide file tree

Showing 59 changed files with 920 additions and 529 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -37,35 +37,6 @@ module.exports = {
 				selector: 'CallExpression[callee.name="deprecated"] Property[key.name="version"][value.value=/' + majorMinorRegExp + '/]',
 				message: 'Deprecated functions must be removed before releasing this version.',
 			},
-			{
-				// Builds a selector which handles CallExpression with path
-				// argument at varied position by function.
-				//
-				// See: https://github.com/WordPress/gutenberg/pull/9615
-				selector: map( {
-					1: [
-						'property',
-						'matchesProperty',
-						'path',
-					],
-					2: [
-						'invokeMap',
-						'get',
-						'has',
-						'hasIn',
-						'invoke',
-						'result',
-						'set',
-						'setWith',
-						'unset',
-						'update',
-						'updateWith',
-					],
-				}, ( functionNames, argPosition ) => (
-					`CallExpression[callee.name=/^(${ functionNames.join( '|' ) })$/] > Literal:nth-child(${ argPosition })`
-				) ).join( ',' ),
-				message: 'Always pass an array as the path argument',
-			},
 			{
 				selector: 'CallExpression[callee.name=/^(__|_x|_n|_nx)$/] Literal[value=/\\.{3}/]',
 				message: 'Use ellipsis character (…) in place of three dots',

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -57,10 +57,10 @@
 		"@wordpress/wordcount": "file:packages/wordcount"
 	},
 	"devDependencies": {
-		"@babel/core": "7.2.2",
+		"@babel/core": "7.4.4",
 		"@babel/plugin-syntax-jsx": "7.2.0",
-		"@babel/runtime-corejs2": "7.3.1",
-		"@babel/traverse": "7.2.3",
+		"@babel/runtime-corejs3": "7.4.4",
+		"@babel/traverse": "7.4.4",
 		"@wordpress/babel-plugin-import-jsx-pragma": "file:packages/babel-plugin-import-jsx-pragma",
 		"@wordpress/babel-plugin-makepot": "file:packages/babel-plugin-makepot",
 		"@wordpress/babel-preset-default": "file:packages/babel-preset-default",
@@ -84,7 +84,7 @@
 		"chalk": "2.4.1",
 		"concurrently": "3.5.0",
 		"copy-webpack-plugin": "4.5.2",
-		"core-js": "2.5.7",
+		"core-js": "3.0.1",
 		"cross-env": "3.2.4",
 		"cssnano": "4.1.10",
 		"deasync": "0.1.14",

diff --git a/packages/README.md b/packages/README.md
@@ -29,7 +29,7 @@ When creating a new package, you need to provide at least the following:
 		"module": "build-module/index.js",
 		"react-native": "src/index",
 		"dependencies": {
-			"@babel/runtime": "^7.0.0"
+			"@babel/runtime": "^7.4.4"
 		},
 		"publishConfig": {
 			"access": "public"

diff --git a/packages/a11y/package.json b/packages/a11y/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/dom-ready": "file:../dom-ready"
 	},
 	"publishConfig": {

diff --git a/packages/annotations/package.json b/packages/annotations/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/data": "file:../data",
 		"@wordpress/hooks": "file:../hooks",
 		"@wordpress/i18n": "file:../i18n",

diff --git a/packages/api-fetch/package.json b/packages/api-fetch/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/i18n": "file:../i18n",
 		"@wordpress/url": "file:../url"
 	},

diff --git a/packages/autop/package.json b/packages/autop/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1"
+		"@babel/runtime": "^7.4.4"
 	},
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/babel-plugin-makepot/package.json b/packages/babel-plugin-makepot/package.json
@@ -29,7 +29,7 @@
 	"main": "build/index.js",
 	"module": "build-module/index.js",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"gettext-parser": "^1.3.1",
 		"lodash": "^4.17.11"
 	},

diff --git a/packages/babel-preset-default/CHANGELOG.md b/packages/babel-preset-default/CHANGELOG.md
@@ -1,8 +1,9 @@
-## 4.1.0 (unreleased)
+## Unreleased
 
-### New Feature
+### New Features
 
 - Handle `<></>` JSX Fragments with `@wordpress/element` `Fragment` ([#15120](https://github.com/WordPress/gutenberg/pull/15120)).
+- The bundled `@babel/core` dependency has been updated from requiring `^7.2.2` to requiring `^7.4.4`. Babel preset is now using `core-js@3` instead of `core-js@2` (see [Migration Guide](https://babeljs.io/blog/2019/03/19/7.4.0#migration-from-core-js-2)).
 
 ## 4.0.0 (2019-03-06)
 

diff --git a/packages/babel-preset-default/index.js b/packages/babel-preset-default/index.js
@@ -19,6 +19,7 @@ module.exports = function( api ) {
 
 		if ( isTestEnv ) {
 			opts.useBuiltIns = 'usage';
+			opts.corejs = 3;
 		} else {
 			opts.modules = false;
 			opts.targets = {

diff --git a/packages/babel-preset-default/package.json b/packages/babel-preset-default/package.json
@@ -27,13 +27,13 @@
 	],
 	"main": "index.js",
 	"dependencies": {
-		"@babel/core": "^7.2.2",
+		"@babel/core": "^7.4.4",
 		"@babel/plugin-proposal-async-generator-functions": "^7.2.0",
-		"@babel/plugin-proposal-object-rest-spread": "^7.3.2",
+		"@babel/plugin-proposal-object-rest-spread": "^7.4.4",
 		"@babel/plugin-transform-react-jsx": "^7.3.0",
-		"@babel/plugin-transform-runtime": "^7.2.0",
-		"@babel/preset-env": "^7.3.1",
-		"@babel/runtime": "^7.3.1",
+		"@babel/plugin-transform-runtime": "^7.4.4",
+		"@babel/preset-env": "^7.4.4",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/babel-plugin-import-jsx-pragma": "file:../babel-plugin-import-jsx-pragma",
 		"@wordpress/browserslist-config": "file:../browserslist-config"
 	},

diff --git a/packages/babel-preset-default/test/__snapshots__/index.js.snap b/packages/babel-preset-default/test/__snapshots__/index.js.snap
@@ -30,7 +30,7 @@ describe('Babel preset default', function () {
               return _context.stop();
           }
         }
-      }, _callee, this);
+      }, _callee);
     }));
     return _foo.apply(this, arguments);
   }
@@ -63,7 +63,7 @@ describe('Babel preset default', function () {
             return _context2.stop();
         }
       }
-    }, _callee2, this);
+    }, _callee2);
   })));
 });"
 `;
diff --git a/packages/blob/package.json b/packages/blob/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1"
+		"@babel/runtime": "^7.4.4"
 	},
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/block-editor/package.json b/packages/block-editor/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.0.0",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/a11y": "file:../a11y",
 		"@wordpress/blob": "file:../blob",
 		"@wordpress/blocks": "file:../blocks",

diff --git a/packages/block-library/package.json b/packages/block-library/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/autop": "file:../autop",
 		"@wordpress/blob": "file:../blob",
 		"@wordpress/block-editor": "file:../block-editor",

diff --git a/packages/block-serialization-default-parser/package.json b/packages/block-serialization-default-parser/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1"
+		"@babel/runtime": "^7.4.4"
 	},
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/blocks/package.json b/packages/blocks/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/autop": "file:../autop",
 		"@wordpress/blob": "file:../blob",
 		"@wordpress/block-serialization-default-parser": "file:../block-serialization-default-parser",

diff --git a/packages/components/package.json b/packages/components/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/a11y": "file:../a11y",
 		"@wordpress/api-fetch": "file:../api-fetch",
 		"@wordpress/compose": "file:../compose",

diff --git a/packages/compose/package.json b/packages/compose/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/element": "file:../element",
 		"@wordpress/is-shallow-equal": "file:../is-shallow-equal",
 		"lodash": "^4.17.11"

diff --git a/packages/core-data/package.json b/packages/core-data/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/api-fetch": "file:../api-fetch",
 		"@wordpress/data": "file:../data",
 		"@wordpress/deprecated": "file:../deprecated",

diff --git a/packages/custom-templated-path-webpack-plugin/package.json b/packages/custom-templated-path-webpack-plugin/package.json
@@ -28,7 +28,7 @@
 	"main": "build/index.js",
 	"module": "build-module/index.js",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"escape-string-regexp": "^1.0.5"
 	},
 	"peerDependencies": {

diff --git a/packages/data/package.json b/packages/data/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/compose": "file:../compose",
 		"@wordpress/deprecated": "file:../deprecated",
 		"@wordpress/element": "file:../element",

diff --git a/packages/date/package.json b/packages/date/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"moment": "^2.22.1",
 		"moment-timezone": "^0.5.16"
 	},

diff --git a/packages/deprecated/package.json b/packages/deprecated/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/hooks": "file:../hooks"
 	},
 	"publishConfig": {

diff --git a/packages/dom-ready/package.json b/packages/dom-ready/package.json
@@ -20,7 +20,7 @@
 	"main": "build/index.js",
 	"module": "build-module/index.js",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1"
+		"@babel/runtime": "^7.4.4"
 	},
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/dom/package.json b/packages/dom/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"lodash": "^4.17.11"
 	},
 	"publishConfig": {

diff --git a/packages/e2e-test-utils/package.json b/packages/e2e-test-utils/package.json
@@ -28,7 +28,7 @@
 	"main": "build/index.js",
 	"module": "build-module/index.js",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/keycodes": "file:../keycodes",
 		"@wordpress/url": "file:../url",
 		"lodash": "^4.17.11",

diff --git a/packages/e2e-tests/jest.config.js b/packages/e2e-tests/jest.config.js
@@ -7,8 +7,4 @@ module.exports = {
 		'<rootDir>/config/setup-test-framework.js',
 		'expect-puppeteer',
 	],
-	transformIgnorePatterns: [
-		'node_modules',
-		'scripts/config/puppeteer.config.js',
-	],
 };
diff --git a/packages/e2e-tests/specs/preview.test.js b/packages/e2e-tests/specs/preview.test.js
@@ -100,7 +100,7 @@ describe( 'Preview', () => {
 
 		// When autosave completes for a new post, the URL of the editor should
 		// update to include the ID. Use this to assert on preview URL.
-		const [ , postId ] = await( await editorPage.waitForFunction( () => {
+		const [ , postId ] = await ( await editorPage.waitForFunction( () => {
 			return window.location.search.match( /[\?&]post=(\d+)/ );
 		} ) ).jsonValue();
 

diff --git a/packages/edit-post/package.json b/packages/edit-post/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/a11y": "file:../a11y",
 		"@wordpress/api-fetch": "file:../api-fetch",
 		"@wordpress/block-editor": "file:../block-editor",

diff --git a/packages/edit-widgets/package.json b/packages/edit-widgets/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.0.0",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/block-editor": "file:../block-editor",
 		"@wordpress/components": "file:../components",
 		"@wordpress/element": "file:../element",

diff --git a/packages/editor/package.json b/packages/editor/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/api-fetch": "file:../api-fetch",
 		"@wordpress/blob": "file:../blob",
 		"@wordpress/block-editor": "file:../block-editor",

diff --git a/packages/element/package.json b/packages/element/package.json
@@ -22,7 +22,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/escape-html": "file:../escape-html",
 		"lodash": "^4.17.11",
 		"react": "^16.8.4",

diff --git a/packages/escape-html/package.json b/packages/escape-html/package.json
@@ -20,7 +20,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1"
+		"@babel/runtime": "^7.4.4"
 	},
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -18,7 +18,7 @@
 		"url": "https://github.com/WordPress/gutenberg/issues"
 	},
 	"dependencies": {
-		"babel-eslint": "^8.0.3",
+		"babel-eslint": "^10.0.1",
 		"eslint-plugin-jsx-a11y": "^6.2.1",
 		"eslint-plugin-react": "^7.12.4",
 		"eslint-plugin-react-hooks": "^1.6.0",

diff --git a/packages/format-library/package.json b/packages/format-library/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1",
+		"@babel/runtime": "^7.4.4",
 		"@wordpress/block-editor": "file:../block-editor",
 		"@wordpress/components": "file:../components",
 		"@wordpress/editor": "file:../editor",

diff --git a/packages/hooks/package.json b/packages/hooks/package.json
@@ -21,7 +21,7 @@
 	"module": "build-module/index.js",
 	"react-native": "src/index",
 	"dependencies": {
-		"@babel/runtime": "^7.3.1"
+		"@babel/runtime": "^7.4.4"
 	},
 	"publishConfig": {
 		"access": "public"