Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-activated font faces are not removed when saving a theme #656

Open
matiasbenedetto opened this issue May 30, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@matiasbenedetto
Copy link
Contributor

What

If specific font faces are deactivated and the changes are saved in the editor, and after that the theme is saved using CBT, the resulting theme still have the de-activated font faces.

Screenscast

Screencast.from.30-05-24.12.52.39.webm

Expected

The deactivated font faces should be removed from the saved theme.

@pbking
Copy link
Contributor

pbking commented May 30, 2024

Ahh, I tried to reproduce but couldn't until I realized (with the help of your video) that it only happens when SOME (but not ALL) of the font faces are deactivated.

Relatedly (I think...), if you deactivate SOME of the font faces (for example, 3 of an available 6) then the Font Library shows that 3/3 variants are active (not 3/6 as I would expect). However if you deactivate all of the Font Faces then 0/6 are shown instead.

So deactivating (and saving) ALL of the Font Faces causes the entire Font Family to be removed. But deactivating (and saving) SOME of the Font Faces results in NONE of the Font Faces to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants