fix: move marker image loading earlier in process #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
madwort
commented
Feb 26, 2021
madwort
commented
- reproducible issues were observed where marker icons don't display at initial zoom, but visible at other zoom levels
- reproducible on Android browsers
- also in Firefox desktop with connection throttling set to "Regular 3G"
- caused by marker image not loaded in time
- in theory we can use 'styleimagemissing' to handle this, but this does not work with image files loaded via callback, only for inline generated images
* reproducible issues were observed where marker icons don't display at initial zoom, but visible at other zoom levels * reproducible on Android browsers * also in Firefox desktop with connection throttling set to "Regular 3G" * caused by marker image not loaded in time * in theory we can use ['styleimagemissing'](mapbox/mapbox-gl-js#7987) to handle this, but this does not work with image files loaded via callback, only for inline generated images
|
@trovster any objections to this? I might also add a |
trovster
approved these changes
Feb 26, 2021
Sounds find to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.